Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [ltt-dev] [RFC] UST instrumentation API
Date: Wed, 13 Apr 2011 16:59:08 -0400	[thread overview]
Message-ID: <20110413205908.GA10716@Krystal> (raw)

OK, so I took care of most of the instrumentation API, but some
questions need discussion.

* Tracepoints:

 - Currently handled:

#include <ust/tracepoint.h>

tracepoint(name, ...)
register_tracepoint(name, ...)
unregister_tracepoint(name, ...)
TRACEPOINT_LIB

- Questions/suggestions:

About:
DECLARE_TRACE()
DEFINE_TRACE()

-> given that the API presented to users will be "TRACE_EVENT()" (which
we should rename to something else to eliminate confusion), it might
make sense to make both of DECLARE_TRACE and DEFINE_TRACE internal to
tracepoints and don't expose them to the users.

TRACE_EVENT() could be the macro replacing these, but I would recommend
using a name like "TRACEPOINT_TEMPLATE()", which is what it really is.

TP_PARAMS()
TP_PROTO()
TP_ARGS()

I recommend to merge all these into "TP_PARAMS()". Through the
"TRACEPOINT_TEMPLATE()" macro, these will all become internal anyway, so
not exposed to the users.


UST Markers (main API members):

#include <ust/marker.h>

ust_marker(name, "fmt", ...)
UST_MARKER_NOARGS
GET_UST_MARKER()
DEFINE_UST_MARKER(name, ...)
ust_marker_probe_unregister()
ust_marker_probe_register()
ust_marker_synchronize_unregister()
UST_MARKER_LIB

Will be eventually phased-out with the new TRACEPOINT_TEMPLATE() and CTF:
DEFINE_UST_MARKER_TP()
ust_marker_tp()

Feedback is welcome,

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com




             reply	other threads:[~2011-04-13 20:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 20:59 Mathieu Desnoyers [this message]
2011-04-14 14:53 ` David Goulet
2011-04-14 19:02   ` Nils Carlson
2011-04-14 19:28     ` Mathieu Desnoyers
2011-04-19 21:56       ` Mathieu Desnoyers
2011-04-20 18:03         ` Nils Carlson
2011-04-20 18:03           ` Nils Carlson
2011-04-20 18:03           ` Nils Carlson
2011-04-20 18:10           ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413205908.GA10716@Krystal \
    --to=mathieu.desnoyers@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox