From mboxrd@z Thu Jan 1 00:00:00 1970 From: compudj@krystal.dyndns.org (Mathieu Desnoyers) Date: Fri, 12 Nov 2010 07:30:18 -0500 Subject: [ltt-dev] [PATCH 2/2] introduce uatomic_and and uatomic_or In-Reply-To: <4CDD32AC.2050308@redhat.com> References: <1289552247-18130-1-git-send-email-pbonzini@redhat.com> <1289552247-18130-3-git-send-email-pbonzini@redhat.com> <20101112120846.GB27929@Krystal> <4CDD2F69.7020407@redhat.com> <20101112121900.GA29642@Krystal> <4CDD31E7.1050500@redhat.com> <4CDD32AC.2050308@redhat.com> Message-ID: <20101112123018.GB30826@Krystal> * Paolo Bonzini (pbonzini at redhat.com) wrote: > On 11/12/2010 01:24 PM, Paolo Bonzini wrote: >> Should I rename uatomic_add to uatomic_xchg_add too (I prefer this name >> to uatomic_return_add)? > > Uh, uatomic_add returns void actually. Then returning void from > uatomic_{and,or} is indeed more consistent. Ah! I knew we'd find the culprit!! ;-) Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com