[ltt-dev] [UST PATCH] null check for disable_marker

[compudj@krystal.dyndns.org (Mathieu Desnoyers)]

* Douglas Santos (douglas.santos at polymtl.ca) wrote:
> ---
>  libust/tracectl.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/libust/tracectl.c b/libust/tracectl.c
> index f1b644c..dd61ebe 100644
> --- a/libust/tracectl.c
> +++ b/libust/tracectl.c
> @@ -1064,7 +1064,9 @@ int process_client_cmd(char *recvbuf, struct ustcomm_source *src)
>  
>  		result = sscanf(channel_slash_name, "%a[^/]/%as", &channel_name, &marker_name);
>  
> -		if(marker_name == NULL) {
> +		if(channel_name == NULL || marker_name == NULL) {
> +			WARN("invalid marker name");
> +			goto next_cmd;

Please look just above in the same function, you'll notice a sscanf with
255 char limits rather than "%a". It's odd to have both which are
different in the same function. Anyone willing to make them all the same ?
(%a is preferred, as it does not have a static size limit)

Thanks,

Mathieu

>  		}
>  
>  		result = ltt_marker_disconnect(channel_name, marker_name, "default");
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com