From mboxrd@z Thu Jan  1 00:00:00 1970
From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Date: Wed, 17 Feb 2010 22:28:26 -0500
Subject: [ltt-dev] [PATCH 11/12] avoid multiple evaluation
	of	STORE_SHARED argument
In-Reply-To: <1266260686-17588-12-git-send-email-pbonzini@redhat.com>
References: <1266260686-17588-1-git-send-email-pbonzini@redhat.com>
	<1266260686-17588-12-git-send-email-pbonzini@redhat.com>
Message-ID: <20100218032826.GH11338@Krystal>

* Paolo Bonzini (pbonzini at redhat.com) wrote:
> Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>

Acked-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

Can you please resend the whole patchset after taking my comments into
account ? There is less risk of mistakes like that.  Please append the
Acked-by to the patches already acked so I can skip them in the next
rounds of review.

Thanks,

Mathieu

> ---
>  urcu/system.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/urcu/system.h b/urcu/system.h
> index e36a13b..0c3152f 100644
> --- a/urcu/system.h
> +++ b/urcu/system.h
> @@ -46,9 +46,9 @@
>   */
>  #define STORE_SHARED(x, v)		\
>  	({				\
> -		_STORE_SHARED(x, v);	\
> +		typeof(x) _v = _STORE_SHARED(x, v);	\
>  		smp_wmc();		\
> -		(v);			\
> +		_v;			\
>  	})
>  
>  #endif /* _URCU_SYSTEM_H */
> -- 
> 1.6.6
> 
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68