From mboxrd@z Thu Jan  1 00:00:00 1970
From: mingo@elte.hu (Ingo Molnar)
Date: Thu, 30 Apr 2009 18:00:54 +0200
Subject: [ltt-dev] [PATCH] Fix dirty page accounting
	in	redirty_page_for_writepage()
In-Reply-To: <alpine.DEB.1.10.0904301114440.4028@qirst.com>
References: <20090430024303.GB19875@Krystal>
	<alpine.DEB.1.10.0904300921290.22262@qirst.com>
	<20090430133859.GB8329@elte.hu>
	<alpine.DEB.1.10.0904300938220.22262@qirst.com>
	<20090430141446.GD14696@elte.hu>
	<alpine.DEB.1.10.0904301013110.14178@qirst.com>
	<20090430143819.GF14696@elte.hu>
	<alpine.DEB.1.10.0904301042170.4028@qirst.com>
	<20090430150142.GC20580@elte.hu>
	<alpine.DEB.1.10.0904301114440.4028@qirst.com>
Message-ID: <20090430160054.GB4723@elte.hu>


* Christoph Lameter <cl at linux.com> wrote:

> http://article.gmane.org/gmane.linux.kernel.cross-arch/1128
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1132
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1134
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1138
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1139
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1145 VM stats
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1160 NFS stats
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1161 Genhd stats
> http://article.gmane.org/gmane.linux.kernel.cross-arch/1164 SRCU

The new percpu APIs could be used in most of these places already, 
straight away. This is a really good TODO list for places to 
enhance.

Then a second set of patches could convert percpu_add() / etc. uses 
to __percpu_add() ... but that should be done by those architectures 
that need it (and to the extent they need it), because it's not 
really testable on x86.

I dont really like the PER_CPU / CPU_INC etc. type of all-capitals 
APIs you introduced in the patches above:


+		__CPU_INC(bt->sequence);
+	CPU_FREE(bt->sequence);

was there any strong reason to go outside the well-established 
percpu_* name space and call these primitives as if they were 
macros?

	Ingo