From mboxrd@z Thu Jan  1 00:00:00 1970
From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Date: Wed, 29 Apr 2009 09:30:40 -0400
Subject: [ltt-dev] Compilation error of trace_clock for PowerPC (ppc32)
In-Reply-To: <6213bc560904290558g7c445f5an6e2b857f4d3a1553@mail.gmail.com>
References: <6213bc560904282339o20ceb41ei90e5c3767fe15612@mail.gmail.com>
	<20090429124206.GA32163@Krystal>
	<6213bc560904290558g7c445f5an6e2b857f4d3a1553@mail.gmail.com>
Message-ID: <20090429133040.GA1966@Krystal>

* srikanth krishnakar (skrishnakar at gmail.com) wrote:
> Hi Mathieu,
> 
> On Wed, Apr 29, 2009 at 6:12 PM, Mathieu Desnoyers <
> compudj at krystal.dyndns.org> wrote:
> 
> > * srikanth krishnakar (skrishnakar at gmail.com) wrote:
> > > Hi Mathieu,
> > >
> > > Testing with latest LTTng verison 2.6.29-lttng-0.122  for kernel
> > > linux-2.6.29 gives following compile error for PowerPC architecture :
> > >
> > > ---------------------------
> > > LTTng : 2.6.29-lttng-0.122
> > > Kernel : Linux-2.6.29
> > > Arch: PPC_32
> > > Toolchain: ppc_440
> > > ---------------------------
> > >
> > > In file included from include/linux/trace-clock.h:13,
> > >                  from include/linux/ltt-tracer.h:22,
> > >                  from kernel/marker.c:29:
> > > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h: In function
> > > ?trace_clock_read32?:
> > > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h:18: error:
> > > implicit declaration of function ?get_tbl?
> > > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h: In function
> > > ?trace_clock_read64?:
> > > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h:23: error:
> > > implicit declaration of function ?get_tb?
> > > make[1]: *** [kernel/marker.o] Error 1
> > > make: *** [kernel] Error 2
> > >
> > > This error is first seen in :
> > >
> > > *2.6.29-rc8-lttng-0.112
> > >
> > > Continues till 2.6.29-lttng-0.122
> > > *
> > >
> > > As per your earlier request I am attaching the default .config used while
> > > compilation.
> > >
> > >
> > > Can you please submit a fix for this error ???
> > >
> >
> > Yes, I think I'll need your full .config.
> >
> > And please try 2.6.29.1-lttng-0.124, just to be sure. I remember doing a
> > fix in this area not so long ago, but looking at my current powerpc
> > trace-clock.h there seems to be no obvious change since lttng 0.112.
> 
> 
> For LTTng 2.6.29-lttng-0.124 I see the same errors as shown below:
> 
> In file included from include/linux/trace-clock.h:13,
>                  from include/linux/ltt-tracer.h:22,
>                  from kernel/marker.c:29:
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h: In function
> ?trace_clock_read32?:
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h:18: error: implicit
> declaration of function ?get_tbl?
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h: In function
> ?trace_clock_read64?:
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h:23: error: implicit
> declaration of function ?get_tb?
> make[1]: *** [kernel/marker.o] Error 1
> make: *** [kernel] Error 2
> [root at srikant linux-2.6-lttng]#
> 
> Seems still the error exists.
> 
> -Srikanth
> 

Can you try adding :

#include <asm/time.h>

at the beginning of arch/powerpc/include/asm/trace-clock.h ?

If it works, I'll release a fix.

Thanks,

Mathieu

> >
> >
> > Mathieu
> >
> > > Regards
> > > Srikanth Krishnakar
> > > **********************
> >
> >
> > > _______________________________________________
> > > ltt-dev mailing list
> > > ltt-dev at lists.casi.polymtl.ca
> > > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> >
> >
> > --
> > Mathieu Desnoyers
> > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
> >
> 
> 
> 
> -- 
> "The Good You Do, The Best You GET"
> 
> Regards
> Srikanth Krishnakar
> **********************

> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev


-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68