From mboxrd@z Thu Jan  1 00:00:00 1970
From: mingo@elte.hu (Ingo Molnar)
Date: Tue, 24 Mar 2009 21:47:19 +0100
Subject: [ltt-dev] [patch 6/9] LTTng instrumentation - timer
In-Reply-To: <alpine.LFD.2.00.0903242011520.29264@localhost.localdomain>
References: <20090324155625.420966314@polymtl.ca>
	<20090324160148.754766083@polymtl.ca>
	<20090324182122.GG31117@elte.hu>
	<alpine.LFD.2.00.0903242011520.29264@localhost.localdomain>
Message-ID: <20090324204719.GA24320@elte.hu>


* Thomas Gleixner <tglx at linutronix.de> wrote:

> On Tue, 24 Mar 2009, Ingo Molnar wrote:
> > the init methods are missing from your patch entirely - and the rest 
> > is partially incomplete as well.
> > 
> > Instrumentation of the del_timer() variants is missing. For a 
> > complete lifetime analysis of timers this cannot be left out.
> 
> Look at the debugobjects hooks. They cover the complete timer life 
> time already.
> 
> Piggypacking tracepoints on those would simplify maintenance and 
> reduce the number of extra lines in the code.

makes sense. They dont cover itimers nor hrtimers though.

	Ingo