From mboxrd@z Thu Jan  1 00:00:00 1970
From: mingo@elte.hu (Ingo Molnar)
Date: Tue, 24 Mar 2009 19:01:23 +0100
Subject: [ltt-dev] [patch 4/9] LTTng instrumentation softirq
In-Reply-To: <20090324160148.396496293@polymtl.ca>
References: <20090324155625.420966314@polymtl.ca>
	<20090324160148.396496293@polymtl.ca>
Message-ID: <20090324180123.GF31117@elte.hu>


* Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca> wrote:

> Compared to Jason's patch, this patch also instruments softirq raise event.

Mind sending this on top of Jason's patch, which is already applied 
to the tracing tree?

Note, your instrumentation misses one source of softirq raise 
events:

> @@ -300,6 +306,7 @@ void irq_exit(void)
>   */
>  inline void raise_softirq_irqoff(unsigned int nr)
>  {
> +	trace_irq_softirq_raise(nr);
>  	__raise_softirq_irqoff(nr);

__raise_softirq_irqoff() is used in the networking tree. It makes 
little sense to instrument raise_softirq_irqoff() while not 
instrumenting __raise_softirq_irqoff().

	Ingo