From mboxrd@z Thu Jan  1 00:00:00 1970
From: kosaki.motohiro@jp.fujitsu.com (KOSAKI Motohiro)
Date: Fri, 20 Feb 2009 10:39:38 +0900 (JST)
Subject: [ltt-dev] [patch 3/7] OMAP ltt statedump include irq.h
In-Reply-To: <20090219031036.GA6922@Krystal>
References: <20090219092000.954D.A69D9226@jp.fujitsu.com>
	<20090219031036.GA6922@Krystal>
Message-ID: <20090220103732.43F8.A69D9226@jp.fujitsu.com>

> * KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> > > Needed by ARM.
> > > 
> > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca>
> > > ---
> > >  ltt/ltt-statedump.c |    4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > Index: linux-omap-2.6/ltt/ltt-statedump.c
> > > ===================================================================
> > > --- linux-omap-2.6.orig/ltt/ltt-statedump.c	2009-02-15 18:28:09.000000000 +0000
> > > +++ linux-omap-2.6/ltt/ltt-statedump.c	2009-02-15 18:28:42.000000000 +0000
> > > @@ -30,6 +30,10 @@
> > >  #include <linux/fdtable.h>
> > >  #include <linux/swap.h>
> > >  
> > > +#ifdef CONFIG_GENERIC_HARDIRQS
> > > +#include <linux/irq.h>
> > > +#endif
> > > +
> > 
> > Why is this needed for arm?
> > 
> > irq.h says
> > 
> > /*
> >  * Please do not include this file in generic code.  There is currently
> >  * no requirement for any architecture to implement anything held
> >  * within this file.
> >  *
> >  * Thanks. --rmk
> >  */
> > 
> > So, irq.h including often bring strange problem.
> > There is irqnr.h for for architecture generic interface.
> > 
> > if irqnr.h don't have enough interface, let't me know this.
> > 
> 
> Without the linux/irq.h include, I get the following error message when
> compiling LTTng over the 2.6.29-rc4-omap1 tree :
> 
> ltt/ltt-statedump.c: In function 'list_interrupts':
> ltt/ltt-statedump.c:233: error: dereferencing pointer to incomplete type
> ltt/ltt-statedump.c:235: error: dereferencing pointer to incomplete type
> ltt/ltt-statedump.c:236: error: dereferencing pointer to incomplete type
> ltt/ltt-statedump.c:240: error: dereferencing pointer to incomplete type
> make[1]: *** [ltt/ltt-statedump.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> 
> It looks like struct irq_desc is not defined there, although we need
> it. Any better idea on how to fix it ?

After thinking whole time, I reached a conclusion that you are right.
Please ignore my last mail.

thanks.