From mboxrd@z Thu Jan  1 00:00:00 1970
From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Date: Wed, 18 Feb 2009 22:10:36 -0500
Subject: [ltt-dev] [patch 3/7] OMAP ltt statedump include irq.h
In-Reply-To: <20090219092000.954D.A69D9226@jp.fujitsu.com>
References: <20090218074703.163707091@polymtl.ca>
	<20090218075132.634544029@polymtl.ca>
	<20090219092000.954D.A69D9226@jp.fujitsu.com>
Message-ID: <20090219031036.GA6922@Krystal>

* KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> > Needed by ARM.
> > 
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca>
> > ---
> >  ltt/ltt-statedump.c |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > Index: linux-omap-2.6/ltt/ltt-statedump.c
> > ===================================================================
> > --- linux-omap-2.6.orig/ltt/ltt-statedump.c	2009-02-15 18:28:09.000000000 +0000
> > +++ linux-omap-2.6/ltt/ltt-statedump.c	2009-02-15 18:28:42.000000000 +0000
> > @@ -30,6 +30,10 @@
> >  #include <linux/fdtable.h>
> >  #include <linux/swap.h>
> >  
> > +#ifdef CONFIG_GENERIC_HARDIRQS
> > +#include <linux/irq.h>
> > +#endif
> > +
> 
> Why is this needed for arm?
> 
> irq.h says
> 
> /*
>  * Please do not include this file in generic code.  There is currently
>  * no requirement for any architecture to implement anything held
>  * within this file.
>  *
>  * Thanks. --rmk
>  */
> 
> So, irq.h including often bring strange problem.
> There is irqnr.h for for architecture generic interface.
> 
> if irqnr.h don't have enough interface, let't me know this.
> 

Without the linux/irq.h include, I get the following error message when
compiling LTTng over the 2.6.29-rc4-omap1 tree :

ltt/ltt-statedump.c: In function 'list_interrupts':
ltt/ltt-statedump.c:233: error: dereferencing pointer to incomplete type
ltt/ltt-statedump.c:235: error: dereferencing pointer to incomplete type
ltt/ltt-statedump.c:236: error: dereferencing pointer to incomplete type
ltt/ltt-statedump.c:240: error: dereferencing pointer to incomplete type
make[1]: *** [ltt/ltt-statedump.o] Error 1
make[1]: *** Waiting for unfinished jobs....

It looks like struct irq_desc is not defined there, although we need
it. Any better idea on how to fix it ?

Mathieu

> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68