Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: kosaki.motohiro@jp.fujitsu.com (KOSAKI Motohiro)
Subject: [ltt-dev] LTTng 0.74 for Linux 2.6.28 (ext4 tracepoints) (fixed in LTTng 0.78)
Date: Wed, 14 Jan 2009 08:57:21 +0900 (JST)	[thread overview]
Message-ID: <20090114085427.442F.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <20090113225827.GA5791@Krystal>

> * KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> > Hi Mathieu
> > 
> > 2009/1/11 Mathieu Desnoyers <compudj at krystal.dyndns.org>:
> > > Hi,
> > >
> > > LTTng 0.74 fixes the probe Makefile to build the net-trace probe module.
> > > It also adds jbd2 and ext4 tracepoints, and jbd2 probe module.
> > 
> > -ECANTBUILD
> > 
> 
> Hi Kosaki,
> 
> Thanks for the report. This should be fixed in LTTng 0.78 now.
> 
> Best regards,

Unfortunately, lockdep part also can't build.

==
Subject: [PATCH] fix lockdep tracing build error

commit 6afe40b4dace385d7ba2faf24b352f066f3b71bf rename argument a0 to ip.
it cause following build error to lttng tree.

  CC      kernel/lockdep.o
kernel/lockdep.c: In function 'trace_hardirqs_on_caller':
kernel/lockdep.c:2186: error: 'a0' undeclared (first use in this function)
kernel/lockdep.c:2186: error: (Each undeclared identifier is reported only once
kernel/lockdep.c:2186: error: for each function it appears in.)
kernel/lockdep.c: In function 'trace_hardirqs_off_caller':
kernel/lockdep.c:2241: error: 'a0' undeclared (first use in this function)
make[1]: *** [kernel/lockdep.o] Error 1


therefore we also need change trace argument.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
 kernel/lockdep.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 2ec98a3..21ef2ad 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -2183,7 +2183,7 @@ void trace_hardirqs_on_caller(unsigned long ip)
 
 	time_hardirqs_on(CALLER_ADDR0, ip);
 
-	_trace_lockdep_hardirqs_on(a0);
+	_trace_lockdep_hardirqs_on(ip);
 
 	if (unlikely(!debug_locks || current->lockdep_recursion))
 		return;
@@ -2238,7 +2238,7 @@ void trace_hardirqs_off_caller(unsigned long ip)
 
 	time_hardirqs_off(CALLER_ADDR0, ip);
 
-	_trace_lockdep_hardirqs_off(a0);
+	_trace_lockdep_hardirqs_off(ip);
 
 	if (unlikely(!debug_locks || current->lockdep_recursion))
 		return;
-- 
1.6.0.6











  reply	other threads:[~2009-01-13 23:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-09 23:54 [ltt-dev] LTTng 0.73 for Linux 2.6.28 Mathieu Desnoyers
2009-01-10 16:11 ` [ltt-dev] LTTng 0.74 for Linux 2.6.28 (ext4 tracepoints) Mathieu Desnoyers
2009-01-13 22:33   ` KOSAKI Motohiro
2009-01-13 22:58     ` [ltt-dev] LTTng 0.74 for Linux 2.6.28 (ext4 tracepoints) (fixed in LTTng 0.78) Mathieu Desnoyers
2009-01-13 23:57       ` KOSAKI Motohiro [this message]
2009-01-14  5:20         ` Mathieu Desnoyers
2009-01-14  0:13       ` Theodore Tso
2009-01-15  1:45         ` Mathieu Desnoyers
2009-01-15  3:20           ` Mathieu Desnoyers
2009-01-12 10:33 ` [ltt-dev] LTTng 0.73 for Linux 2.6.28 Akyurek, Ali (EXT)
2009-01-12 16:38   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090114085427.442F.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox