From mboxrd@z Thu Jan 1 00:00:00 1970 From: compudj@krystal.dyndns.org (Mathieu Desnoyers) Date: Fri, 9 Jan 2009 09:51:52 -0500 Subject: [ltt-dev] [PATCH] lttng: Fix list-break bug In-Reply-To: <49671D62.6080903@cn.fujitsu.com> References: <49671D62.6080903@cn.fujitsu.com> Message-ID: <20090109145152.GC7262@Krystal> * Gui Jianfeng (guijianfeng at cn.fujitsu.com) wrote: > Hi Mathieu > When removing ltt-tracer module, OOPS happens. > Because "tmp = ltt_traces.head;" breaks the list. > This patch fix it. > Will merge, thanks ! Mathieu > Signed-off-by: Gui Jianfeng > --- > ltt/ltt-tracer.c | 6 +----- > 1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/ltt/ltt-tracer.c b/ltt/ltt-tracer.c > index af14135..ceb0c04 100644 > --- a/ltt/ltt-tracer.c > +++ b/ltt/ltt-tracer.c > @@ -1159,20 +1159,16 @@ static void __exit ltt_exit(void) > { > struct ltt_trace_struct *trace; > struct list_head *pos, *n; > - struct list_head tmp; > > ltt_lock_traces(); > /* Stop each trace, currently being read by RCU read-side */ > list_for_each_entry_rcu(trace, <t_traces.head, list) > _ltt_trace_stop(trace); > - tmp = ltt_traces.head; > - /* empty the original list head */ > - INIT_LIST_HEAD(<t_traces.head); > /* Wait for quiescent state. Readers have preemption disabled. */ > synchronize_sched(); > /* Safe iteration is now permitted. It does not have to be RCU-safe > * because no readers are left. */ > - list_for_each_safe(pos, n, &tmp) { > + list_for_each_safe(pos, n, <t_traces.head) { > trace = container_of(pos, struct ltt_trace_struct, list); > /* _ltt_trace_destroy does a synchronize_sched() */ > _ltt_trace_destroy(trace); > -- > 1.5.4.rc3 > > -- > Regards > Gui Jianfeng > > > _______________________________________________ > ltt-dev mailing list > ltt-dev at lists.casi.polymtl.ca > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev > -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68