Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: randy.dunlap@oracle.com (Randy Dunlap)
Subject: [ltt-dev] [PATCH] Simple LTTng userspace events through debugfs
Date: Thu, 18 Dec 2008 08:50:18 -0800	[thread overview]
Message-ID: <20081218085018.8bd1fd92.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20081217173223.GA32699@Krystal>

On Wed, 17 Dec 2008 12:32:24 -0500 Mathieu Desnoyers wrote:

> Index: linux-2.6-lttng/ltt/ltt-userspace-event.c
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6-lttng/ltt/ltt-userspace-event.c	2008-12-17 12:03:43.000000000 -0500
> @@ -0,0 +1,129 @@
> +
> +/**
> + * write_event: write a userspace string into the trace stream

Hi Mathieu,

Please make above line:

 * write_event - write a userspace string into the trace system

Thanks.

> + * @file: file pointer
> + * @user_buf: user string
> + * @count: length to copy, including the final NULL
> + * @ppos: unused
> + *
> + * Copy a string into a trace event, in channel "userspace", event "event".
> + * Copies until either \n or \0 is reached.
> + * On success, returns the number of bytes copied from the source, including the
> + * \n or \0 character (if there was one in the count range). It cannot return
> + * more than count.
> + * Inspired from tracing_mark_write implementation from Steven Rostedt and
> + * Ingo Molnar.
> + */
> +static ssize_t write_event(struct file *file, const char __user *user_buf,
> +		size_t count, loff_t *ppos)
> +{


---
~Randy




  reply	other threads:[~2008-12-18 16:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15 23:10 Mathieu Desnoyers
2008-12-16 19:42 ` Ingo Molnar
2008-12-17  4:16   ` Mathieu Desnoyers
2008-12-17 17:32     ` Mathieu Desnoyers
2008-12-18 16:50       ` Randy Dunlap [this message]
2008-12-18 16:58         ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081218085018.8bd1fd92.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox