Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: mathieu.desnoyers@polymtl.ca (Mathieu Desnoyers)
Subject: [ltt-dev] A problem in net instrumentation code of lttng-0.64
Date: Tue, 9 Dec 2008 11:07:30 -0500	[thread overview]
Message-ID: <20081209160730.GA24235@Krystal> (raw)
In-Reply-To: <da1db2080812082309rd7859e0ga36fe4828a85b362@mail.gmail.com>

* Sunzen Wang (sunzen at gmail.com) wrote:
> Hi Mathieu,
> 
> I found a strange problem in net instrumentation code while scanning
> lttng instrumentation code via gitweb, and would like to inform you
> with the attached patch.
> 
> Is it ok?  If you have noticed it, just ignore it. If it is a not
> problem, please teach me.
> 
> Thanks,

Hi Suzen,

Yes, the problem you identified must be fixed. I'll apply your patch
into the next LTTng release.

Mathieu

(your patch pasted here)


diff -Naru linux-2.6.27.8-lttng-0.64/net/core/dev.c linux-2.6.27.8-lttng-new/net/core/dev.c
--- linux-2.6.27.8-lttng-0.64/net/core/dev.c	2008-12-09 14:51:16.972757754 +0800
+++ linux-2.6.27.8-lttng-new/net/core/dev.c	2008-12-09 14:54:00.636758086 +0800
@@ -2336,7 +2336,7 @@
 {
 	unsigned long flags;
 
-	trace_net_napi_poll(n);
+	trace_net_napi_schedule(n);
 
 	local_irq_save(flags);
 	list_add_tail(&n->poll_list, &__get_cpu_var(softnet_data).poll_list);
-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68




       reply	other threads:[~2008-12-09 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <da1db2080812082309rd7859e0ga36fe4828a85b362@mail.gmail.com>
2008-12-09 16:07 ` Mathieu Desnoyers [this message]
2008-12-09 20:38   ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081209160730.GA24235@Krystal \
    --to=mathieu.desnoyers@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox