From mboxrd@z Thu Jan  1 00:00:00 1970
From: mathieu.desnoyers@polymtl.ca (Mathieu Desnoyers)
Date: Tue, 2 Dec 2008 11:31:45 -0500
Subject: [ltt-dev] Make menuconfig finery
In-Reply-To: <4934D7CE.6050502@cn.fujitsu.com>
References: <4934D7CE.6050502@cn.fujitsu.com>
Message-ID: <20081202163145.GC19095@Krystal>

* Zhaolei (zhaolei at cn.fujitsu.com) wrote:
> It we don't select markers, and enter lttng's menuitem, we will
> see this screen:
>  .config - Linux Kernel v2.6.27.7 Configuration
>  ------------------------------------------------------------------------------
>   |-------------------------- Linux Trace Toolkit --------------------------|
>   |  Arrow keys navigate the menu.  <Enter> selects submenus --->.          |
>   |  Highlighted letters are hotkeys.  Pressing <Y> includes, <N> excludes, |
>   |  <M> modularizes features.  Press <Esc><Esc> to exit, <?> for Help, </> |
>   |  for Search.  Legend: [*] built-in  [ ] excluded  <M> module  < >       |
>   | |---------------------------------------------------------------------| |
>   | |    ^@                                                               | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |                                                                     | |
>   | |---------------------------------------------------------------------| |
>   |-------------------------------------------------------------------------|
>   |                    <Select>    < Exit >    < Help >                     |
>   |-------------------------------------------------------------------------|
> 
> It isn't beautiful.
> We can avoid this blank screen by this patch.
> 

Integrated into lttng-menus.patch and fixed the following patches.

Thanks !

MAthieu

> Signed-off-by: Zhao Lei <zhaolei at cn.fujitsu.com>
> ---
>  ltt/Kconfig |   14 ++++----------
>  1 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/ltt/Kconfig b/ltt/Kconfig
> index 341f178..8629321 100644
> --- a/ltt/Kconfig
> +++ b/ltt/Kconfig
> @@ -1,6 +1,4 @@
> -menu "Linux Trace Toolkit"
> -
> -config LTT
> +menuconfig LTT
>  	bool "Linux Trace Toolkit Instrumentation Support"
>  	depends on EXPERIMENTAL
>  	depends on TRACEPOINTS
> @@ -28,9 +26,10 @@ config LTT
>  	  please check the following address :
>  	       http://ltt.polymtl.ca
>  
> +if LTT
> +
>  config LTT_TRACEPROBES
>  	tristate "Compile lttng tracing probes"
> -	depends on LTT
>  	default m
>  	help
>  	  Compile lttng tracing probes, which connect to the tracepoints when
> @@ -79,7 +78,6 @@ config LTT_RELAY_CHECK_RANDOM_ACCESS
>  config LTT_SERIALIZE
>  	tristate "Linux Trace Toolkit Serializer"
>  	default y
> -	depends on LTT
>  	help
>  	  Library for serializing information from format string and argument
>  	  list to the trace buffers.
> @@ -93,7 +91,6 @@ config LTT_MARKER_CONTROL
>  
>  config LTT_TRACER
>  	tristate "Linux Trace Toolkit Tracer"
> -	depends on LTT
>  	depends on LTT_MARKER_CONTROL
>  	default y
>  	help
> @@ -112,7 +109,6 @@ config LTT_TRACER
>  
>  config LTT_ALIGNMENT
>  	bool "Align Linux Trace Toolkit Traces"
> -	depends on LTT
>  	default y if !HAVE_EFFICIENT_UNALIGNED_ACCESS
>  	help
>  	  This option enables dynamic alignment of data in buffers. The
> @@ -125,14 +121,12 @@ config LTT_ALIGNMENT
>  
>  config LTT_DEBUG_EVENT_SIZE
>  	bool "Add event size field to LTT events for tracer debugging"
> -	depends on LTT
>  	default n
>  	help
>  	  Tracer-internal option to help debugging event type encoding problems.
>  
>  config LTT_VMCORE
>  	bool "Support trace extraction from crash dump"
> -	depends on LTT
>  	default y
>  	help
>  	  If you enable this option, the Linux Trace Toolkit Tracer will
> @@ -180,4 +174,4 @@ config LTT_FTRACE
>  	  function tracing while a trace is being taken. Typically used when the
>  	  surroundings of a problem has been identified in a prior trace.
>  
> -endmenu
> +endif # LTT
> -- 
> 1.5.5.3
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68