From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Subject: [ltt-dev] lttng: Fix possible memory leak in ltt-tracer.c
Date: Tue, 21 Oct 2008 10:11:30 -0400 [thread overview]
Message-ID: <20081021141130.GC19039@Krystal> (raw)
In-Reply-To: <48FD909D.2000906@cn.fujitsu.com>
* Wei Yongjun (yjwei at cn.fujitsu.com) wrote:
> ltt_traces <../cgi-bin/global.cgi?pattern=ltt_traces&type=symbol>.head
> <../cgi-bin/global.cgi?pattern=head&type=symbol> is saved to tmp, and is
> empty after the following code:
> INIT_LIST_HEAD(<t_traces.head);
> So remove the tracers will take no effect.
>
> This patch fix to remove tracers used tmp.
>
> Signed-off-by: Wei Yongjun <yjwei at cn.fujitsu.com>
>
Yep, good catch. Thanks !
Acked-by: Mathieu Desnoyers <mathieu.desnoyers at polymtl.ca>
> diff --git a/ltt/ltt-tracer.c b/ltt/ltt-tracer.c
> index bc8251b..6109fb6 100644
> --- a/ltt/ltt-tracer.c
> +++ b/ltt/ltt-tracer.c
> @@ -818,7 +818,7 @@ static void __exit ltt_exit(void)
> synchronize_sched();
> /* Safe iteration is now permitted. It does not have to be RCU-safe
> * because no readers are left. */
> - list_for_each_safe(pos, n, <t_traces.head) {
> + list_for_each_safe(pos, n, &tmp) {
> trace = container_of(pos, struct ltt_trace_struct, list);
> /* _ltt_trace_destroy does a synchronize_sched() */
> _ltt_trace_destroy(trace);
>
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
prev parent reply other threads:[~2008-10-21 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 8:19 Wei Yongjun
2008-10-21 14:11 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021141130.GC19039@Krystal \
--to=compudj@krystal.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox