From: paulmck@linux.vnet.ibm.com (Paul E. McKenney)
Subject: [ltt-dev] [PATCH] rcu: RCU-based detection of stalled CPUs for Classic RCU, fix
Date: Fri, 3 Oct 2008 08:14:31 -0700 [thread overview]
Message-ID: <20081003151431.GC6246@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081003084233.GA15637@elte.hu>
On Fri, Oct 03, 2008 at 10:42:33AM +0200, Ingo Molnar wrote:
>
> -tip testing found a minor build bug - find the fix below.
>
> Ingo
>
> -------------------->
> >From 2ec2b482b10a1ed3493c224f1893cddd3d33833b Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@elte.hu>
> Date: Fri, 3 Oct 2008 10:41:00 +0200
> Subject: [PATCH] rcu: RCU-based detection of stalled CPUs for Classic RCU, fix
>
> fix the !CONFIG_RCU_CPU_STALL_DETECTOR path:
>
> kernel/rcuclassic.c: In function '__rcu_pending':
> kernel/rcuclassic.c:609: error: too few arguments to function 'check_cpu_stall'
>
> Signed-off-by: Ingo Molnar <mingo at elte.hu>
> ---
> kernel/rcuclassic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
> index 0d07e6e..37f72e5 100644
> --- a/kernel/rcuclassic.c
> +++ b/kernel/rcuclassic.c
> @@ -239,7 +239,7 @@ static void record_gp_stall_check_time(struct rcu_ctrlblk *rcp)
> {
> }
>
> -static void check_cpu_stall(struct rcu_ctrlblk *rcp, struct rcu_data *rdp)
> +static inline void check_cpu_stall(struct rcu_ctrlblk *rcp)
> {
> }
I should have learned by now to test with all relevant config parameter
combinations... My apologies for the hassle!!!
Thanx, Paul
next prev parent reply other threads:[~2008-10-03 15:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081002003628.GA7877@linux.vnet.ibm.com>
[not found] ` <20081002080726.GB17695@elte.hu>
[not found] ` <20081002140507.GB6729@linux.vnet.ibm.com>
[not found] ` <20081002151046.GB2473@Krystal>
[not found] ` <20081002174318.GB7324@linux.vnet.ibm.com>
2008-10-02 18:51 ` [ltt-dev] [PATCH, RFC] RCU-based detection of stalled CPUs for Classic RCU (LTTng support) Mathieu Desnoyers
2008-10-02 22:55 ` Paul E. McKenney
2008-10-02 23:06 ` [ltt-dev] [PATCH tip/master] RCU-based detection of stalled CPUs for Classic RCU Paul E. McKenney
2008-10-03 4:41 ` Mathieu Desnoyers
2008-10-03 5:02 ` Paul E. McKenney
2008-10-03 8:39 ` Ingo Molnar
2008-10-03 8:42 ` [ltt-dev] [PATCH] rcu: RCU-based detection of stalled CPUs for Classic RCU, fix Ingo Molnar
2008-10-03 8:42 ` Ingo Molnar
2008-10-03 15:14 ` Paul E. McKenney [this message]
2008-10-03 15:13 ` [ltt-dev] [PATCH tip/master] RCU-based detection of stalled CPUs for Classic RCU Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003151431.GC6246@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox