From mboxrd@z Thu Jan  1 00:00:00 1970
From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Date: Mon, 17 Feb 2014 16:08:44 +0000 (UTC)
Subject: [lttng-dev] [RFC PATCH lttng-modules] LTTng logger ABI
In-Reply-To: <53022631.90209@opersys.com>
References: <1392502096-1900-1-git-send-email-mathieu.desnoyers@efficios.com>
	<53022631.90209@opersys.com>
Message-ID: <1718413437.26031.1392653324422.JavaMail.zimbra@efficios.com>

----- Original Message -----
> From: "Karim Yaghmour" <karim.yaghmour@opersys.com>
> To: "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
> Cc: lttng-dev at lists.lttng.org
> Sent: Monday, February 17, 2014 10:09:37 AM
> Subject: Re: [RFC PATCH lttng-modules] LTTng logger ABI
> 
> 
> That was quick :)
> 
> On 14-02-15 05:08 PM, Mathieu Desnoyers wrote:
> > Add a user-space ABI (new file /proc/lttng-logger) to lttng-modules
> > which can be written into by any user on the system. The content is
> > saved into the kernel trace stream into the "lttng_logger" kernel event.
> 
> Nice. I think this would do for the use-case we discussed (i.e. feedback
> Android's "ATRACE" events into lttng instead of ftrace's "trace_marker"
> file.)

Great!

> 
> > The content of a single write is written into an lttng_logger event,
> > provided the packet size is large enough to store the content. If it is
> > not large enough, it won't be logged. However we cannot return any error
> > to the caller, since there may be more than one trace session listening
> > to this event.
> 
> Can we just truncate instead of dropping if the event is too large?

I'd be tempted to ask: is that the behavior of ftrace when receiving an
event larger than a page through trace_marker ?

We could indeed truncate the event, but it would increase complexity
compared to the current patch. So I'm tempted to wait a bit before doing so.

Thanks,

Mathieu

> 
> --
> Karim Yaghmour
> CEO - Opersys inc. / www.opersys.com
> http://twitter.com/karimyaghmour
> 
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com