From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [lttng-dev] [PATCH babeltrace] Test ctf-writer: Verify that enumerations are validated before use
Date: Tue, 19 Nov 2013 14:58:32 +0000 (UTC) [thread overview]
Message-ID: <1516856868.70740.1384873112693.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <1384748610-21396-1-git-send-email-jeremie.galarneau@efficios.com>
Merged, thanks!
Mathieu
----- Original Message -----
> From: "J?r?mie Galarneau" <jeremie.galarneau@efficios.com>
> To: lttng-dev at lists.lttng.org
> Sent: Sunday, November 17, 2013 11:23:30 PM
> Subject: [lttng-dev] [PATCH babeltrace] Test ctf-writer: Verify that enumerations are validated before use
>
> Signed-off-by: J?r?mie Galarneau <jeremie.galarneau at efficios.com>
> ---
> tests/lib/test_ctf_writer.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/tests/lib/test_ctf_writer.c b/tests/lib/test_ctf_writer.c
> index d55c629..d7f7db7 100644
> --- a/tests/lib/test_ctf_writer.c
> +++ b/tests/lib/test_ctf_writer.c
> @@ -469,6 +469,7 @@ void type_field_tests()
> struct bt_ctf_field *uint_12;
> struct bt_ctf_field *int_16;
> struct bt_ctf_field *string;
> + struct bt_ctf_field *enumeration;
> struct bt_ctf_field_type *composite_structure_type;
> struct bt_ctf_field_type *structure_seq_type;
> struct bt_ctf_field_type *string_type;
> @@ -477,6 +478,9 @@ void type_field_tests()
> struct bt_ctf_field_type *int_16_type;
> struct bt_ctf_field_type *uint_12_type =
> bt_ctf_field_type_integer_create(12);
> + struct bt_ctf_field_type *enumeration_type;
> + struct bt_ctf_field_type *enumeration_sequence_type;
> + struct bt_ctf_field_type *enumeration_array_type;
>
> ok(uint_12_type, "Create an unsigned integer type");
> ok(bt_ctf_field_type_integer_set_base(uint_12_type,
> @@ -578,9 +582,28 @@ void type_field_tests()
> ok(bt_ctf_field_string_set_value(string, "A value") == 0,
> "Set a string's value");
>
> + enumeration_type = bt_ctf_field_type_enumeration_create(uint_12_type);
> + ok(enumeration_type,
> + "Create an enumeration type with an unsigned 12-bit integer as
> container");
> + enumeration_sequence_type = bt_ctf_field_type_sequence_create(
> + enumeration_type, "count");
> + ok(!enumeration_sequence_type,
> + "Check enumeration types are validated when creating a sequence");
> + enumeration_array_type = bt_ctf_field_type_array_create(
> + enumeration_type, 10);
> + ok(!enumeration_array_type,
> + "Check enumeration types are validated when creating an array");
> + ok(bt_ctf_field_type_structure_add_field(composite_structure_type,
> + enumeration_type, "enumeration") == 0,
> + "Check enumeration types are validated when adding them as structure
> members");
> + enumeration = bt_ctf_field_create(enumeration_type);
> + ok(!enumeration,
> + "Check enumeration types are validated before instantiation");
> +
> bt_ctf_field_put(string);
> bt_ctf_field_put(uint_12);
> bt_ctf_field_put(int_16);
> + bt_ctf_field_put(enumeration);
> bt_ctf_field_type_put(composite_structure_type);
> bt_ctf_field_type_put(structure_seq_type);
> bt_ctf_field_type_put(string_type);
> @@ -588,6 +611,9 @@ void type_field_tests()
> bt_ctf_field_type_put(uint_8_type);
> bt_ctf_field_type_put(int_16_type);
> bt_ctf_field_type_put(uint_12_type);
> + bt_ctf_field_type_put(enumeration_type);
> + bt_ctf_field_type_put(enumeration_sequence_type);
> + bt_ctf_field_type_put(enumeration_array_type);
> }
>
> void packet_resize_test(struct bt_ctf_stream_class *stream_class,
> --
> 1.8.4.2
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
prev parent reply other threads:[~2013-11-19 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 4:23 Jérémie Galarneau
2013-11-19 14:58 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516856868.70740.1384873112693.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox