From mboxrd@z Thu Jan  1 00:00:00 1970
From: jonathan.rajotte-julien@efficios.com (Jonathan Rajotte)
Date: Mon, 21 Sep 2015 14:31:33 -0400
Subject: [lttng-dev] [PATCH lttng-ust] Unnecessary bit shit
Message-ID: <1442860293-20922-1-git-send-email-jonathan.rajotte-julien@efficios.com>

Reported by cppcheck [1].

[1]
https://ci.lttng.org/view/Code%20quality/job/lttng-ust_master_cppcheck/5/cppcheckResult/source.10/

Proposed-by: Michael Jeanson <mjeanson at efficios.com>
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien at efficios.com>
---
 libringbuffer/backend_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libringbuffer/backend_internal.h b/libringbuffer/backend_internal.h
index 344784f..79f8bde 100644
--- a/libringbuffer/backend_internal.h
+++ b/libringbuffer/backend_internal.h
@@ -485,7 +485,7 @@ static inline int lttng_ust_fls(unsigned int x)
 		r -= 2;
 	}
 	if (!(x & 0x80000000U)) {
-		x <<= 1;
+		/* No need to bit shift on last operation */
 		r -= 1;
 	}
 	return r;
-- 
2.1.4