From mboxrd@z Thu Jan 1 00:00:00 1970 From: jdesfossez@efficios.com (Julien Desfossez) Date: Thu, 30 Jul 2015 11:12:37 -0400 Subject: [lttng-dev] [LTTNG-TOOLS PATCH] Fix: only cleanup the agent_apps_ht_by_sock as root Message-ID: <1438269157-1473-1-git-send-email-jdesfossez@efficios.com> Commit 6a4e403927ffef4cae8726064dcf53c463eb128c introduced a bug where we could end up iterating over the agent_apps_ht_by_sock regardless if it was allocated or not (only when the sessiond is launched as root). Steps to reproduce: $ sudo lttng-sessiond -d $ lttng-sessiond Error: Already running daemon. Segmentation fault (core dumped) Signed-off-by: Julien Desfossez --- src/bin/lttng-sessiond/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c index 91dd047..5840165 100644 --- a/src/bin/lttng-sessiond/main.c +++ b/src/bin/lttng-sessiond/main.c @@ -677,7 +677,9 @@ static void sessiond_cleanup(void) } DBG("Cleaning up all agent apps"); - agent_app_ht_clean(); + if (is_root) { + agent_app_ht_clean(); + } DBG("Closing all UST sockets"); ust_app_clean_list(); -- 1.9.1