From: eeppeliteloop@gmail.com (Philippe Proulx)
Subject: [lttng-dev] [PATCH lttng-tools 2/2] Fix: modprobe.c: fix tmp_list memory leak
Date: Tue, 28 Apr 2015 17:09:16 -0400 [thread overview]
Message-ID: <1430255356-6566-1-git-send-email-eeppeliteloop@gmail.com> (raw)
Reported-by: Hannes Weisbach <hannes.weisbach at mailbox.tu-dresden.de>
Signed-off-by: Philippe Proulx <eeppeliteloop at gmail.com>
---
src/bin/lttng-sessiond/modprobe.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/bin/lttng-sessiond/modprobe.c b/src/bin/lttng-sessiond/modprobe.c
index d730a1d..32c4210 100644
--- a/src/bin/lttng-sessiond/modprobe.c
+++ b/src/bin/lttng-sessiond/modprobe.c
@@ -360,11 +360,11 @@ static int append_list_to_probes(const char *list)
{
char *next;
int index = nr_probes, ret;
- char *tmp_list;
+ char *tmp_list, *cur_list;
assert(list);
- tmp_list = strdup(list);
+ cur_list = tmp_list = strdup(list);
if (!tmp_list) {
PERROR("strdup temp list");
return -ENOMEM;
@@ -374,11 +374,11 @@ static int append_list_to_probes(const char *list)
size_t name_len;
struct kern_modules_param *cur_mod;
- next = strtok(tmp_list, ",");
+ next = strtok(cur_list, ",");
if (!next) {
break;
}
- tmp_list = NULL;
+ cur_list = NULL;
/* filter leading spaces */
while (*next == ' ') {
--
2.3.0
reply other threads:[~2015-04-28 21:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430255356-6566-1-git-send-email-eeppeliteloop@gmail.com \
--to=eeppeliteloop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox