From: jeremie.galarneau@efficios.com (Jérémie Galarneau)
Subject: [lttng-dev] [PATCH lttng-ust] Fix: Try loading classes using the thread context class loader
Date: Fri, 31 Oct 2014 14:03:47 -0400 [thread overview]
Message-ID: <1414778627-22489-1-git-send-email-jeremie.galarneau@efficios.com> (raw)
LTTngAgent should load classes using the current thread context's
class loader and then try using the system class loader if a
ClassNotFoundException is thrown.
Signed-off-by: J?r?mie Galarneau <jeremie.galarneau at efficios.com>
---
.../java/org/lttng/ust/agent/LTTngAgent.java | 26 +++++++++++++++++-----
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/liblttng-ust-java-agent/java/org/lttng/ust/agent/LTTngAgent.java b/liblttng-ust-java-agent/java/org/lttng/ust/agent/LTTngAgent.java
index 293ac84..47b4519 100644
--- a/liblttng-ust-java-agent/java/org/lttng/ust/agent/LTTngAgent.java
+++ b/liblttng-ust-java-agent/java/org/lttng/ust/agent/LTTngAgent.java
@@ -94,8 +94,7 @@ public class LTTngAgent {
Class<?> logging;
try {
- ClassLoader loader = ClassLoader.getSystemClassLoader();
- logging = loader.loadClass("org.apache.log4j.spi.LoggingEvent");
+ logging = loadClass("org.apache.log4j.spi.LoggingEvent");
} catch (ClassNotFoundException e) {
/* Log4j classes not found, no need to create the relevant objects */
return false;
@@ -131,10 +130,26 @@ public class LTTngAgent {
return true;
}
+ private Class<?> loadClass(String className) throws ClassNotFoundException {
+ ClassLoader loader;
+ Class<?> loadedClass;
+
+ try {
+ /* Try to load class using the current thread's context class loader */
+ loader = Thread.currentThread().getContextClassLoader();
+ loadedClass = loader.loadClass(className);
+ } catch (ClassNotFoundException e) {
+ /* Loading failed, try using the system class loader */
+ loader = ClassLoader.getSystemClassLoader();
+ loadedClass = loader.loadClass(className);
+ }
+
+ return loadedClass;
+ }
+
private void initAgentJULClasses() {
try {
- ClassLoader loader = ClassLoader.getSystemClassLoader();
- Class<?> lttngJUL = loader.loadClass("org.lttng.ust.agent.jul.LTTngJUL");
+ Class<?> lttngJUL = loadClass("org.lttng.ust.agent.jul.LTTngJUL");
this.julUser = (LogFramework)lttngJUL.getDeclaredConstructor(new Class[] {Boolean.class}).newInstance(false);
this.julRoot = (LogFramework)lttngJUL.getDeclaredConstructor(new Class[] {Boolean.class}).newInstance(true);
this.useJUL = true;
@@ -154,8 +169,7 @@ public class LTTngAgent {
private void initAgentLog4jClasses() {
try {
- ClassLoader loader = ClassLoader.getSystemClassLoader();
- Class<?> lttngLog4j = loader.loadClass("org.lttng.ust.agent.log4j.LTTngLog4j");
+ Class<?> lttngLog4j = loadClass("org.lttng.ust.agent.log4j.LTTngLog4j");
this.log4jUser = (LogFramework)lttngLog4j.getDeclaredConstructor(new Class[] {Boolean.class}).newInstance(false);
this.log4jRoot = (LogFramework)lttngLog4j.getDeclaredConstructor(new Class[] {Boolean.class}).newInstance(true);
this.useLog4j = true;
--
2.1.2
next reply other threads:[~2014-10-31 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 18:03 Jérémie Galarneau [this message]
2014-10-31 18:05 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414778627-22489-1-git-send-email-jeremie.galarneau@efficios.com \
--to=jeremie.galarneau@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox