Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: gbastien+lttng@versatic.net (Geneviève Bastien)
Subject: [lttng-dev] [RFC Patch Ust 1/5] Update data structures to support CTF global structures
Date: Wed, 26 Mar 2014 10:47:08 -0400	[thread overview]
Message-ID: <1395845232-17669-2-git-send-email-gbastien+lttng@versatic.net> (raw)
In-Reply-To: <1395845232-17669-1-git-send-email-gbastien+lttng@versatic.net>

The structures match those in LTTng-tools to support global structures.

The struct lttng_structure contains the global types required by the
structure, but not ustctl_structure because global types will be flattened
in the event description when serializing.

Signed-off-by: Genevi?ve Bastien <gbastien+lttng at versatic.net>
---
 include/lttng/ust-ctl.h    | 14 ++++++++++++++
 include/lttng/ust-events.h | 17 +++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/include/lttng/ust-ctl.h b/include/lttng/ust-ctl.h
index ba3a271..708501d 100644
--- a/include/lttng/ust-ctl.h
+++ b/include/lttng/ust-ctl.h
@@ -265,6 +265,7 @@ enum ustctl_abstract_types {
 	ustctl_atype_sequence,
 	ustctl_atype_string,
 	ustctl_atype_float,
+	ustctl_atype_structure,
 	NR_USTCTL_ABSTRACT_TYPES,
 };
 
@@ -335,6 +336,9 @@ struct ustctl_type {
 			struct ustctl_basic_type length_type;
 			struct ustctl_basic_type elem_type;
 		} sequence;
+		struct {
+			char name[LTTNG_UST_SYM_NAME_LEN];
+		} structure;
 		char padding[USTCTL_UST_TYPE_PADDING];
 	} u;
 } LTTNG_PACKED;
@@ -348,9 +352,18 @@ struct ustctl_enum {
 	char padding[USTCTL_UST_ENUM_TYPE_PADDING];
 } LTTNG_PACKED;
 
+#define USTCTL_UST_STRUCT_TYPE_PADDING	368
+struct ustctl_structure {
+	char name[LTTNG_UST_SYM_NAME_LEN];
+	size_t nr_fields;
+	struct ustctl_field *fields;
+	char padding[USTCTL_UST_STRUCT_TYPE_PADDING];
+};
+
 /* CTF categories for global types declared outside event descriptions */
 enum ustctl_global_type_categories {
 	ustctl_mtype_enum,
+	ustctl_mtype_structure,
 	NR_USTCTL_GLOBAL_TYPES,
 };
 
@@ -359,6 +372,7 @@ struct ustctl_global_type_decl {
 	uint32_t mtype;
 	union {
 		struct ustctl_enum ctf_enum;
+		struct ustctl_structure ctf_structure;
 		char padding[USTCTL_UST_GLOBAL_TYPE_DECL_PADDING];
 	} u;
 } LTTNG_PACKED;
diff --git a/include/lttng/ust-events.h b/include/lttng/ust-events.h
index 6f11e84..89155ae 100644
--- a/include/lttng/ust-events.h
+++ b/include/lttng/ust-events.h
@@ -82,6 +82,7 @@ enum lttng_abstract_types {
 	atype_sequence,
 	atype_string,
 	atype_float,
+	atype_structure,
 	NR_ABSTRACT_TYPES,
 };
 
@@ -96,6 +97,7 @@ enum lttng_string_encodings {
 /* CTF categories for global types declared outside event descriptions */
 enum lttng_global_type_categories {
 	mtype_enum,
+	mtype_structure,
 	NR_GLOBAL_TYPES,
 };
 
@@ -207,6 +209,9 @@ struct lttng_type {
 			struct lttng_basic_type length_type;
 			struct lttng_basic_type elem_type;
 		} sequence;
+		struct {
+			const char *name;
+		} structure;
 		char padding[LTTNG_UST_TYPE_PADDING];
 	} u;
 };
@@ -220,12 +225,24 @@ struct lttng_enum {
 	char padding[LTTNG_UST_ENUM_TYPE_PADDING];
 };
 
+#define LTTNG_UST_STRUCT_TYPE_PADDING 20
+struct lttng_structure {
+	const char *name;
+	size_t nr_fields;
+	const struct lttng_event_field *fields;
+	/* Global types required by this structure. */
+	unsigned int nr_global_type_decl;
+	const struct lttng_global_type_decl *global_type_decl;
+	char padding[LTTNG_UST_STRUCT_TYPE_PADDING];
+};
+
 #define LTTNG_UST_GLOBAL_TYPES_PADDING	60
 struct lttng_global_type_decl {
 	enum lttng_global_type_categories mtype;
 	unsigned int nowrite; /* inherited from the field using it */
 	union {
 		const struct lttng_enum *ctf_enum;
+		const struct lttng_structure *ctf_structure;
 		char padding[LTTNG_UST_GLOBAL_TYPES_PADDING];
 	} u;
 };
-- 
1.9.1




  reply	other threads:[~2014-03-26 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-26 14:47 [lttng-dev] LTTng-UST: Add support of CTF structure global type Geneviève Bastien
2014-03-26 14:47 ` Geneviève Bastien [this message]
2014-03-26 14:47 ` [lttng-dev] [RFC Patch Ust 2/5] Serialize the CTF global structures for ust-comm Geneviève Bastien
2014-03-26 14:47 ` [lttng-dev] [RFC Patch Ust 3/5] Add the macros to generate the data structures for CTF global structures Geneviève Bastien
2014-03-26 14:47 ` [lttng-dev] [RFC Patch Ust 4/5] Update the ctf-global-type example to show the usage of a global structure Geneviève Bastien
2014-03-26 14:47 ` [lttng-dev] [RFC Patch Ust 5/5] Update the LTTng documentation with CTF global structures Geneviève Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395845232-17669-2-git-send-email-gbastien+lttng@versatic.net \
    --to=gbastien+lttng@versatic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox