Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: paul_woegerer@mentor.com (Paul Woegerer)
Subject: [lttng-dev] [PATCH lttng-ust v2] Multisession compatible fix for statedump with JUL tracing
Date: Fri, 29 Nov 2013 14:32:53 +0100	[thread overview]
Message-ID: <1385731974-12135-1-git-send-email-paul_woegerer@mentor.com> (raw)

Unfortunately, the first version of the deadlock fix broke the multi-session
usecase as a side effect.  This revised version works fine even for
multi-session scenarios.

I used the following bash-script for verification:

#!/bin/bash
function session_start {
	lttng create $1
	local SARG="-s $1"
	lttng enable-event -j -a $SARG
	lttng enable-channel -u test $SARG
	lttng enable-event -u -a -c test $SARG
	lttng start $1
}
function session_stop {
	lttng stop $1
}
function session_destroy {
	lttng destroy $1
}

session_start s1
session_start s2
session_start s3
(sleep 6 && session_start a1)&
(sleep 12 && session_start a2)&
(sleep 18 && session_start a3)&

./run

session_stop s1
session_stop s2
session_stop s3
session_stop a1
session_stop a2
session_stop a3

# start a new bash session to allow browsing the results (e.g. lttng view a1, ...)
# exit that session to do the cleanup.
PS1="(browse results) " bash -i

session_destroy s1
session_destroy s2
session_destroy s3
session_destroy a1
session_destroy a2
session_destroy a3
# script-end

Paul Woegerer (1):
  Fix: baddr_statedump deadlock with JUL tracing

 include/lttng/ust-events.h       |  6 ++++++
 liblttng-ust/lttng-events.c      | 19 ++++++++++++++++++-
 liblttng-ust/lttng-tracer-core.h |  3 +--
 liblttng-ust/lttng-ust-comm.c    | 30 +++++++++++++++++-------------
 4 files changed, 42 insertions(+), 16 deletions(-)

-- 
1.8.4




             reply	other threads:[~2013-11-29 13:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 13:32 Paul Woegerer [this message]
2013-11-29 13:32 ` [lttng-dev] [PATCH lttng-ust v2] Fix: baddr_statedump deadlock " Paul Woegerer
2013-11-30 14:44   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385731974-12135-1-git-send-email-paul_woegerer@mentor.com \
    --to=paul_woegerer@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox