From: christian.babeux@efficios.com (Christian Babeux)
Subject: [lttng-dev] [PATCH lttng-tools] Fix: Possible memory leaks when creating filter IR root node
Date: Tue, 23 Oct 2012 15:36:17 -0400 [thread overview]
Message-ID: <1351020977-18412-1-git-send-email-christian.babeux@efficios.com> (raw)
Signed-off-by: Christian Babeux <christian.babeux at efficios.com>
---
src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c
index eec78fc..84122c9 100644
--- a/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c
+++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c
@@ -46,9 +46,11 @@ struct ir_op *make_op_root(struct ir_op *child, enum ir_side side)
case IR_DATA_UNKNOWN:
default:
fprintf(stderr, "[error] Unknown root child data type\n");
+ free(op);
return NULL;
case IR_DATA_STRING:
fprintf(stderr, "[error] String cannot be root data type\n");
+ free(op);
return NULL;
case IR_DATA_NUMERIC:
case IR_DATA_FIELD_REF:
--
1.7.12.2
next reply other threads:[~2012-10-23 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 19:36 Christian Babeux [this message]
2012-10-23 19:57 ` Mathieu Desnoyers
2012-10-25 19:56 ` David Goulet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351020977-18412-1-git-send-email-christian.babeux@efficios.com \
--to=christian.babeux@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox