Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: yannick.brosseau@gmail.com (Yannick Brosseau)
Subject: [ltt-dev] [UST PATCH] Remove the close of the buffers data_ready_fd_* in ust_fork
Date: Tue, 22 Feb 2011 18:57:36 -0500	[thread overview]
Message-ID: <1298419056-4654-1-git-send-email-yannick.brosseau@gmail.com> (raw)

We remove those close, since they are done in the call to
ltt_trace_destroy()
The double close is making the test to fail, since they trigger
unwanted warnings

Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
---
 libust/tracectl.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/libust/tracectl.c b/libust/tracectl.c
index 1bd7229..8e2a249 100644
--- a/libust/tracectl.c
+++ b/libust/tracectl.c
@@ -1589,14 +1589,6 @@ static void ust_fork(void)
 	/* Delete all blocked consumers */
 	cds_list_for_each_entry_safe(buf, buf_tmp, &open_buffers_list,
 				 open_buffers_list) {
-		result = close(buf->data_ready_fd_read);
-		if (result == -1) {
-			PERROR("close");
-		}
-		result = close(buf->data_ready_fd_write);
-		if (result == -1) {
-			PERROR("close");
-		}
 		cds_list_del(&buf->open_buffers_list);
 	}
 
-- 
1.7.2.3




                 reply	other threads:[~2011-02-22 23:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298419056-4654-1-git-send-email-yannick.brosseau@gmail.com \
    --to=yannick.brosseau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox