Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: jason.wessel@windriver.com (Jason Wessel)
Subject: [ltt-dev] [PATCH 3/4] usttrace: Use /bin/sh instead of /bin/bash for busybox compatibility
Date: Tue, 22 Feb 2011 15:48:33 -0600	[thread overview]
Message-ID: <1298411314-25405-4-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1298411314-25405-3-git-send-email-jason.wessel@windriver.com>

The busybox posix like shell does not understand the "function"
directive nor does it understand the syntax for redirecting a file via
a shell expanded variable with $(<$pidfilepath).  Busybox also does
not typically provide a link to /bin/bash since busybox does not
provide bash.

It is possible to work around all these limitations in order to allow
user space tracing to work properly in a busybox based environment
with several syntax changes to the usttrace script.

Signed-off-by: Jason Wessel <jason.wessel at windriver.com>
---
 usttrace |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/usttrace b/usttrace
index 7c34ca2..54266db 100755
--- a/usttrace
+++ b/usttrace
@@ -1,16 +1,16 @@
-#!/bin/bash
+#!/bin/sh
 
 # usttrace  by Pierre-Marc Fournier 2009
 # Distributed under the GPLv2.
 
-function error() {
+error() {
 	echo "$0: error: $1" 2>/dev/stderr
 }
 
-function sighandler() {
+sighandler() {
 	echo "Caught Ctrl-C"
 	if [ -z "${UST_CONSUMERD_PID}" ]; then
-		UST_CONSUMERD_PID="$(<$pidfilepath)"
+		UST_CONSUMERD_PID=`cat $pidfilepath`
 	fi
 	# Tell the daemon to die
 	kill -SIGTERM "${UST_CONSUMERD_PID}"
@@ -44,7 +44,7 @@ fi
 
 BASE_TRACE_DIR="${HOME}/.usttraces"
 
-function usage () {
+usage() {
 	echo "usage:  $0 OPTIONS COMMAND" 2>/dev/stderr
 	echo "" 2>/dev/stderr
 	echo "Options:" 2>/dev/stderr
@@ -134,7 +134,7 @@ then
 	# ust-consumerd writes to pidfile
 	# ust-consumerd closes pidfile
 	# we unblock reading pidfile
-	UST_CONSUMERD_PID="$(<$pidfilepath)"
+	UST_CONSUMERD_PID=`cat $pidfilepath`
 	export UST_DAEMON_SOCKET="${UST_CONSUMERD_SOCKPATH}"
 fi
 
-- 
1.6.6.2





  reply	other threads:[~2011-02-22 21:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 21:48 [ltt-dev] [PATCH 0/4] Embedded UST support for ARM and busybox Jason Wessel
2011-02-22 21:48 ` [ltt-dev] [PATCH 1/4] add ARM specific support for UST Jason Wessel
2011-02-22 21:48   ` [ltt-dev] [PATCH 2/4] add a definition for fls() for ARM, taken from the linux kernel Jason Wessel
2011-02-22 21:48     ` Jason Wessel [this message]
2011-02-22 21:48       ` [ltt-dev] [PATCH 4/4] usttrace: use short signal names for busybox compatibility Jason Wessel
2011-02-22 22:21     ` [ltt-dev] [PATCH 2/4] add a definition for fls() for ARM, taken from the linux kernel Mathieu Desnoyers
2011-02-22 22:31       ` Mathieu Desnoyers
2011-02-22 22:24 ` [ltt-dev] [PATCH 0/4] Embedded UST support for ARM and busybox Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298411314-25405-4-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox