From: yannick.brosseau@gmail.com (Yannick Brosseau)
Subject: [ltt-dev] [LTTV PATCH] Reactivate the constructor of the filter and control dialogs
Date: Fri, 4 Feb 2011 15:58:36 -0500 [thread overview]
Message-ID: <1296853116-17298-1-git-send-email-yannick.brosseau@gmail.com> (raw)
Both constructor were accidently removed in the warning cleanup
Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
---
lttv/modules/gui/filter/filter.c | 5 ++++-
lttv/modules/gui/tracecontrol/tracecontrol.c | 6 +++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/lttv/modules/gui/filter/filter.c b/lttv/modules/gui/filter/filter.c
index 2357465..a69685f 100644
--- a/lttv/modules/gui/filter/filter.c
+++ b/lttv/modules/gui/filter/filter.c
@@ -462,7 +462,10 @@ gui_filter_destructor(FilterViewerData *fvd)
GtkWidget *
h_guifilter(LttvPlugin *plugin)
{
- return NULL;
+ gui_filter(plugin);
+
+ /* TODO ybrosseau 2011-02-04: We should probably return a widget here */
+ return NULL;
}
/**
diff --git a/lttv/modules/gui/tracecontrol/tracecontrol.c b/lttv/modules/gui/tracecontrol/tracecontrol.c
index a02301b..56165d9 100644
--- a/lttv/modules/gui/tracecontrol/tracecontrol.c
+++ b/lttv/modules/gui/tracecontrol/tracecontrol.c
@@ -1242,7 +1242,11 @@ void disarm_clicked (GtkButton *button, gpointer user_data)
GtkWidget *
h_guicontrol(LttvPlugin *plugin)
{
- return NULL;
+ LttvPluginTab *ptab = LTTV_PLUGIN_TAB(plugin);
+ gui_control(ptab) ;
+
+ /* TODO ybrosseau 2011-02-04: We should probably return a widget here */
+ return NULL;
}
/**
--
1.7.2.3
next reply other threads:[~2011-02-04 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 20:58 Yannick Brosseau [this message]
2011-02-04 22:14 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296853116-17298-1-git-send-email-yannick.brosseau@gmail.com \
--to=yannick.brosseau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox