Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [lttng-dev] [RFC PATCH lttng-modules] LTTng logger ABI
Date: Mon, 17 Feb 2014 16:21:47 +0000 (UTC)	[thread overview]
Message-ID: <1098265448.26099.1392654107038.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <53023536.9050007@opersys.com>

----- Original Message -----
> From: "Karim Yaghmour" <karim.yaghmour@opersys.com>
> To: "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
> Cc: lttng-dev at lists.lttng.org
> Sent: Monday, February 17, 2014 11:13:42 AM
> Subject: Re: [RFC PATCH lttng-modules] LTTng logger ABI
> 
> 
> On 14-02-17 11:08 AM, Mathieu Desnoyers wrote:
> > I'd be tempted to ask: is that the behavior of ftrace when receiving an
> > event larger than a page through trace_marker ?
> 
> I've never bothered looking it up to be quite honest.

I'm seeing here that the event in trace_marker is limited to 1 page (it can
cross a page boundary, so ftrace deals with 2 pages at most). It makes sense,
since Ftrace's buffers are split into pages.

Its truncation happens here:

        if (cnt > TRACE_BUF_SIZE)
                cnt = TRACE_BUF_SIZE;

> 
> > We could indeed truncate the event, but it would increase complexity
> > compared to the current patch. So I'm tempted to wait a bit before doing
> > so.
> 
> What's the maximum length of events lttng-logger will take? We just
> truncate in the Android user-space library that writes the atrace events.

The minimum size of sub-buffers (trace packets) LTTng can allocate is a page.
However, the available space for event records is slightly less, since we have
a packet header at the beginning of the packet. Since the packet header can
be extended between LTTng versions, it's hard to say. The space can be
slightly less if event contexts are enabled (this can be done dynamically
at runtime, per-buffer).

Thoughts ?

Thanks,

Mathieu

> 
> --
> Karim Yaghmour
> CEO - Opersys inc. / www.opersys.com
> http://twitter.com/karimyaghmour
> 
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com



  reply	other threads:[~2014-02-17 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 22:08 Mathieu Desnoyers
2014-02-17 15:09 ` Karim Yaghmour
2014-02-17 16:08   ` Mathieu Desnoyers
2014-02-17 16:13     ` Karim Yaghmour
2014-02-17 16:21       ` Mathieu Desnoyers [this message]
2014-02-17 16:26         ` Karim Yaghmour
2014-02-17 16:40           ` Mathieu Desnoyers
2014-02-17 16:41             ` Karim Yaghmour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098265448.26099.1392654107038.JavaMail.zimbra@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox