From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [lttng-dev] Missing discarded events message in live-reading mode
Date: Thu, 28 Sep 2017 14:04:03 +0000 (UTC) [thread overview]
Message-ID: <1066884817.20960.1506607443853.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <CAMYaK0RsEf4NaEV5ATXDyVoWq4sWQ5uLu4eWW0nVOzn43VwWGw@mail.gmail.com>
---- On Sep 20, 2017, at 5:37 AM, liguang li <liguang.lee6 at gmail.com> wrote:
> Hi,
> Babeltrace in live mode is not displaying the discarded events message. But
> on CTF traces the discarded events message will be printed on stderr.
> Why? Is there any restriction?
> I added the following patch into the ctf_live_packet_seek() function, and found
> it works well. Is there any side effect?
Hi,
I re-implemented this patch to have the proper declarations exported, and tested
it. It indeed works fine, and I don't expect odd side-effects.
See https://lists.lttng.org/pipermail/lttng-dev/2017-September/027485.html
for the resulting patch.
Thanks,
Mathieu
> diff --git a/formats/lttng-live/lttng-live-comm.c
> b/formats/lttng-live/lttng-live-comm.c
> index a1c95bb..dc14bf5 100644
> --- a/formats/lttng-live/lttng-live-comm.c
> +++ b/formats/lttng-live/lttng-live-comm.c
> @@ -1297,6 +1297,11 @@ retry:
> ctf_update_current_packet_index(&file_stream->parent,
> prev_index, cur_index);
> + if ((&file_stream->parent)->stream_class->trace->parent.collection) {
> + ctf_print_discarded_lost(stderr, &file_stream->parent);
> + }
> +
> +
> file_stream->parent.cycles_timestamp =
> cur_index->ts_cycles.timestamp_begin;
> file_stream->parent.real_timestamp =
> ...
> Regards,
> Liguang
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.lttng.org/pipermail/lttng-dev/attachments/20170928/6993a543/attachment.html>
prev parent reply other threads:[~2017-09-28 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 9:37 liguang li
2017-09-28 14:04 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1066884817.20960.1506607443853.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox