Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: nils.carlson@ludd.ltu.se (Nils Carlson)
Subject: [ltt-dev] [UST PATCH] remove duplicate return
Date: Sat, 11 Sep 2010 20:36:22 +0200	[thread overview]
Message-ID: <01E50955-FF68-4BAD-BF7E-5C6619020D15@ludd.ltu.se> (raw)
In-Reply-To: <1283729203-4435-1-git-send-email-douglas.santos@polymtl.ca>

Could you strike the other return statement? So we keep the error  
message?

/Nils
On Sep 6, 2010, at 1:26 AM, Douglas Santos wrote:

> ---
> libustcmd/ustcmd.c |    5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/libustcmd/ustcmd.c b/libustcmd/ustcmd.c
> index cf6b9d7..825a649 100644
> --- a/libustcmd/ustcmd.c
> +++ b/libustcmd/ustcmd.c
> @@ -381,11 +381,6 @@ int ustcmd_get_cmsf(struct marker_status  
> **cmsf, const pid_t pid)
> 		return -1;
> 	}
>
> -	if (result != 1) {
> -		ERR("error while getting markers list");
> -		return -1;
> -	}
> -
> 	tmp_cmsf = (struct marker_status *) malloc(sizeof(struct  
> marker_status) *
> 		(ustcmd_count_nl(big_str) + 1));
> 	if (tmp_cmsf == NULL) {
> -- 
> 1.7.0.4
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev





      parent reply	other threads:[~2010-09-11 18:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-05 23:26 Douglas Santos
2010-09-06  0:49 ` Mathieu Desnoyers
2010-09-06  1:03   ` Pierre-Marc Fournier
2010-09-06  2:42     ` Mathieu Desnoyers
2010-09-06 15:29       ` Mathieu Desnoyers
2010-09-06 20:14         ` Pierre-Marc Fournier
2010-09-07 15:43           ` Mathieu Desnoyers
2010-09-08 16:29             ` David Goulet
2010-09-08 16:40               ` Mathieu Desnoyers
2010-09-09  7:10             ` Pierre-Marc Fournier
2010-09-09 16:38               ` Mathieu Desnoyers
2010-09-09 17:05                 ` David Goulet
2010-09-11 18:36 ` Nils Carlson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01E50955-FF68-4BAD-BF7E-5C6619020D15@ludd.ltu.se \
    --to=nils.carlson@ludd.ltu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox