From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85305 invoked by alias); 14 Dec 2016 12:32:29 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 85289 invoked by uid 89); 14 Dec 2016 12:32:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_40,SPF_PASS autolearn=ham version=3.3.2 spammy=16-12-13, uncompressed, 161213, H*RU:Unknown_Domain X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Dec 2016 12:32:17 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by (Symantec Mail Security) with SMTP id BB.5B.21704.ECB31585; Wed, 14 Dec 2016 13:32:15 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 14 Dec 2016 13:32:33 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=antoine.tremblay@ericsson.com; Received: from elxa4wqvvz1 (192.75.88.130) by HE1PR0701MB1884.eurprd07.prod.outlook.com (10.167.247.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.771.4; Wed, 14 Dec 2016 12:32:12 +0000 References: <20161214091811.GH25542@E107787-LIN> User-agent: mu4e 0.9.17; emacs 25.1.1 From: Antoine Tremblay To: Yao Qi CC: Tim Newsome , Antoine Tremblay , gdb Subject: Re: read target register to decide breakpoint size In-Reply-To: <20161214091811.GH25542@E107787-LIN> Date: Wed, 14 Dec 2016 12:32:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: AM4PR0101CA0051.eurprd01.prod.exchangelabs.com (10.165.22.147) To HE1PR0701MB1884.eurprd07.prod.outlook.com (10.167.247.24) X-MS-Office365-Filtering-Correlation-Id: f8ad1c5d-b7ef-4023-e39c-08d4241d3b6d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0701MB1884; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;3:s1REY7eJW3LUW7pPstGyljaiv2xi6sXUqKJ8mEJp9B+NgONWGCRRg5nNoy2hLlHbG98SUP3ACa7Dnx0bc2f9MDd0YkZVH6dz8XXpxG7CIIfS9aa9qsIMFevvqAQJ7dMLmyaV8/l/LDQZTj7HD8+qv1Vm3KqYRRZ2F7O8jtQhR/9id49mr8E2cSK9Ka9+8raWeDVteoHwMLOLCu9z2BG0+FGhmqR7bma9DigS9bWNC8x8+Okns9muXf7kl2BVOeZaPrFwddSSekXHqAfFUK3ciQ== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;25:WnhHpbmq5RyHjZ9cngjIpyg+hMLRTJy+9ls5lVOnQAtkM7ZzSWU+zMlu0Jzfl734ec/LVbsAqxKM+nZjqqTQ2JNfhbIPC9EP8ebhpsb9Zkvdu5bPz8NYbqNeQ0NSHJNtdH7mjOF37QtrP/iKmk0y1dHK6tFN7bif0ED3sOk61QMbmf7GbUyEWo2A4hVAD7gkrQkO5p+JDR6TIq34GL9sok/1NwkdFa2Aay7sZchuet0bWjdWxEwq73YcyzEoVN+FWLejIRB9lptZXguaHi5URUtI9z6tNTgwu0q9aFhPBhkdvpFfNzt+juRONwqZ8rBZqJg3VCG8p2EG2eFvprVxa+MeKOQbJj/qALhCgMnSw43FYO1YLOq+CllujEs4crAaOo0S57/MEUvSpc2uRSp4jIwzZI5qD2EuadHsiHxFjZ2Qt+xVsLXcQ+eKYGNE2E/mvFtMeZ+mvmFeoJJJ26a8Q/99Di44nrHeMBaCLBnOH9HJ67DLj5r6Tn2LJ9Wo4gaMOCdL4dboJ50dpwkHiihSlUba7yUKWqQwq7Uomj6NQL8u5t0HloGN9lVNow6Lk7QhROSjCQrQok317eDLn3WNj2wpNRAXyKCHkzW1VXlmdCXZkBlR1kHZaqdNflN0LyDxaPzflZMeeNa4n0m8PjRTKAuapWePMwMrWEuY/mWaJ27T0JZtBmAQDm3Fe0Ykmg/NdbvVNeYIpTKvx6nkbh6MG0PQ7z4nerRrDBuCqbgCcBGRuo0nWNVYyyzB/IS/zshtV20yzpEn6cDwMQpP7oV1cw== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;31:NWKQ2cgK357edFZeGlpvrPZ3ET3j0j0nJXholTiXeTzZIe64m5TpjLpEwZi0vavLw4nV6NSKaVzu+jk62cl8vveEiVX1mEanJ8djXKi1QDZqEgo8VBT8Rxsu1ZnI9hlyVLCkBCI1P2lAwJ/6jk5McXAvfZWNFmf8c2zHHQGyng+E0EBYujxdg4wU3xSdN0O7YgnfDTG1Q4IKLi3rRMoDW8ST7bjO9u5hmigqfGjf43uKXp3ku+VHb8Q8C5FxVaSQ;20:rA4iUJn0b/INk3rfHWjqOL3dLb0T3v9DhZYbmt9Vc+MqigIfTgPnlvQYTiv/WDDDwuM45M4RE2wpMhaK2h73mZ5TpihnTEZL4W4r1S6YNiRLzdB0r+Fu9r82KGCJ2u4hNjQpYpjijG/Nchx7qI7XJYYIvy3LZJuuSzix36hZXCDapx5/wLUABc/SjFkwBjLBlCJVW/JMvEs2nTu3jNkhWKx7NRvEghShTaNiuKeB4MPaj8Yt9HVBDOrvVeVoXpYPLIBtrB89BqNjHErqdjPo4ld/36arBMXjecsGe94CBU3yS/SIavdafOlNbdK439cGMHyKplKJo1+srvOta4/DzJjeQpUbE3Sw4ISYaC6vQn9kcVjML/TY5e5v/nUx4nyl2j7GFDgVa+zXXIyWQkQM6sr1x0vKfkcyA9IybTZ2WHmzPtQciHOcyRKwVWY6B5qpRzTeFOKnBfPewd9l2jSooQ3qpwvhXqhwQuNJxAONbAa4CZ7OfiXPUIZv1FnYvFxm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:HE1PR0701MB1884;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0701MB1884; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;4:zxIqkWzz9NyaQxT7JHvvZd69VBL/jREgS2NKPGztZ8/Peh6fuBI3Za1z9xR4hIPkU24Nnt5qqKXpxSVz8SHdn9jm1ZU3y/Dj1ltEvktw/CsZRe9n4G8PiZbCfAaFo3gVWVu8+0Qrawaz79So2fBHAA9dbXy4uIJVhqLBC18fwhKR/2fJz9JGF/+evXjBgpa7cF4oj1DrTZ96CVOB+S4Wg8BNYTX0An1eTCsQUzwi+SMZnZG87/+GPdZ1PmCrJJEZfNHa+tlfYbsLcdIEPzj/D7Uj47Q1wA3vQFuHk+cBNWqrywtLHsBpuqwHbY+KhsmUFo+x3fRB++en9iX9FYDoW8l6jw7SN/1cklCDA3XPS/LFVHJnRStPqAcH4dWMlVVgUJTSLSqAKN3HF3ODWRBqenAYUNKV5tRmRfICTXNS5xruGWu/FUy42ZZzDcwMPhgqV056yWJRt9T5+xP2I2u6bQ+NlBASompgIiiQ1ZGTLAs7+t+VSgNLuewuL2Rz/XoqCwSf7ih8bkXYdIXbz3r0hAkYSwa0V2JgxIELX2Aft5R/a5WkjakotHAPG1RVm614VaOd6hDoBvFSOZvA/dvcaFN5CstmDBu9Ngxk4YpQpzM1/Ahr3N/u9aGMAg15ECKh X-Forefront-PRVS: 01565FED4C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39850400002)(39450400003)(39840400002)(39410400002)(39860400002)(189002)(199003)(377424004)(24454002)(4001350100001)(1411001)(6666003)(47776003)(6916009)(66066001)(110136003)(36756003)(5660300001)(101416001)(8676002)(81156014)(2950100002)(81166006)(92566002)(97736004)(189998001)(33646002)(5003940100001)(6486002)(6496003)(68736007)(229853002)(2906002)(4326007)(93886004)(38730400001)(3846002)(48376002)(50466002)(6116002)(42186005)(7736002)(305945005)(105586002)(106356001)(76176999)(83506001)(86362001)(39060400001)(54356999)(50986999);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0701MB1884;H:elxa4wqvvz1;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0701MB1884;23:BQAJpWDsOUFaaczEPHR38FdPnvraHcHkeum2gFs?= =?us-ascii?Q?g8KI614r3sGl04ezT+W5JCSn4w/WIGe9pyQC1nkQZWsC5f1xaTYMogCiCf0V?= =?us-ascii?Q?5Ua1fJ/pethZUGokzMaBM8L9HTWkbIN6PgFMN9EAVsEI30FtSw1L3tthAv3e?= =?us-ascii?Q?UlyhJmSAlqq51J5hiMB2g5N/xbdSL69Ji3foqK6WlTyDnJczj3PFWxsg/qHw?= =?us-ascii?Q?pbR36KmWLkOGsUp1K1XidDNl41iRM6t11ZmyPJlHR1thoP49yR99UQq72VUM?= =?us-ascii?Q?kx2YTi+hkT/P3vfJQUG49MIFjGFaMX6dEE/u7ok+oUglkhUnF4wNE4S4vuFc?= =?us-ascii?Q?QbJEx+Mh+bX9WGRw0dAI1XTq+llwVPKUFhAz/9PqGvgslQ3ilgyddlmbu0Vh?= =?us-ascii?Q?GIRZj7IxK7RGfLpBPUdAsPDqwuQ3L+kGgHU1AJw1b1/O5422hQ39AnYx8O2y?= =?us-ascii?Q?VF6Mt0GNljVHTD8EAGZGP2n2HgPrQ7RzcSvT/Ww1Pwn3QFHpEnei41clLaF1?= =?us-ascii?Q?5qlXjnVBZmiUZoiXn82TqsyN8VTsdTq5xioeWb8Hfk/oyTkLi+5rKbZhruM1?= =?us-ascii?Q?laEUKjkWntwr5cU0Z85oqO/DaDhonWHa4nZ63HBZqo7DR6U2YlNNlp/ACVgE?= =?us-ascii?Q?UQZqTCLbKCvSavSxky1Mekmy/y9Y4/9ulR9IJqyTkUx7Hsh6KZqSFj6TXzk9?= =?us-ascii?Q?QZU1ynVSjBzssUjCR9IT3gpdQxrw3iWYCQ7XEf7kSdflBTHgSKn35G/rXcri?= =?us-ascii?Q?NDS8pmbVYy+Q1VNxzVpJ1oQm81yIx2qCNytXz8cnRQbQqzbEuMOo969wvAvo?= =?us-ascii?Q?Ul7kjzG6MNaOJvqTNSkj5WEM0OEh9Yz3+Pu2NJT2FCfmFjCXxDYTa8BUM9YR?= =?us-ascii?Q?CY6KoaORa9ijFOz5F5CUKUeiJ2XxH8yanl9xULyixWexruWr1yj2TNX4t1Bs?= =?us-ascii?Q?oWOPpoxxCszAi0fHgYiH5kNrKj3qD4Uhn+ewLabbDYbgqNkyzXOfn2gMa5gg?= =?us-ascii?Q?VvE82zi23eveGS04z6oWhfuIKW5waR+tvU45iXfzRyCSYXjP2l0Tnkcd89S+?= =?us-ascii?Q?Rhg4DiI+8dDeYTVIJpLN6PWfWS/ULAbZlyPSJmjqc0iv7nsX39sTEr6HRwrz?= =?us-ascii?Q?8N1I7713mLpuH+q6G2T4kEVPyod8+w7FHq4XxK+0Cn8Fa8CX8rr7kkz7x96L?= =?us-ascii?Q?O9IaPCYxQn6N1cJexeJj47Adg00uDe0ipGDNBKmm7kWRr1D5UBXbUbSvnHcF?= =?us-ascii?Q?MMH1vQSOfI1x6IVSY5XyyZC0W6h17tx2NX0P2400w4HZ3jfsomz+4o/srkD3?= =?us-ascii?Q?kj7K2pRV8AXnA5WOKrSv2WnLuUP72Ol/4aNgIQ3iIZYTk?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;6:noGKFKiCRhrhRVUNp7O8ZaFvolNW4NLeZ7elUrR0ftYq9glEec+oJwgxt5ScllQQbDPzplUYhftZh/uVZBHbxsy9pg4aUKkxkM9weBDpEPECEEsWHoJ2ijL3qDWAc1M8FbN9B3SNR+01PwsAL4WgOl1nOXrmlpheTCJihQYJoHTSWve80cLPF6PqoOOgGt3h9M+qIO379oYfH7U8ZzbWfqqggxMiJ5y7IlmmKudVWaDX6Bt5mO/a1oyMt1j6U3mi4Oupr3vMIKY2jsHYW7nawknjFk8eolKFBvci6whjXxFajwt66STr6b1d6pywyeqcCaukcuus24qjoLvk5WKvttJi34W01QtlBLpxYvQrvfqgz0qbIpnpH6z2C47iPEp20ohIMedGS9o4cBsRPuTq6WoZy5rgJoilkTvZCYekDgM=;5:sKVfWv6L1GP/J+cEf5gYZ+7fXzUZ/nAweiam/y035hFwS1skyDD5IoRp64AgbrEUydz5Tq2eCpt6yQU0pbBcWqPn29oay5l3v43xYqYjkhuQ0VUW/hcK2z38olCrPgQqDTCrYUTvVJzPOMv/c22uyHUfvijgZeYi0JTR7NqR9rg=;24:qCKGM9xl1QPKeKx8EkMkEzvQJRKYTnRN18E5ItHtXYBrWxLCxpWu4tWkjWgT2AuC30LIabuswkvJUOqoJj432DCBIWCF3LeTZWhvznsRUoA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0701MB1884;7:7VbRWOvCMqLdeQxpPU2p8J2b7EcjlQ9SfMDSRU+qOGqU41iD9NsU31bx9ikbltB5NW1TvpENvHgr0CvkOW1fcQBR9ePAij6h+IXsgfhrltIEXQyIMY4+VyqhOEL0GzvscC88QXKBq9kH17um5SSj1P1ssE2TpLiHGPtOqxM51TF+RjB1KQeH/4bZq88+/kgpsEN0BnoYFJmJ52ZH6pLVGyZo/0VvtbxtSMmO5yyrKl+TW0z4hBUmBiueFqeq4rZ/gLuAFvLePo2/UQC064OcDtkeVoe1AwQNrE1gQiSX83CuF7z2URHfU2WWtrP6kJod/fV60S/E3UjGHwkadq2Th8gwt8kogG4ZA5suitZdhCSp6Zp4hW10IgU+8ahGYvDl3BQU2/ba/Okhvd0787n9HTnCJQ1yVINPDeg8H+KLoeJvWSwV6a6MQD0IVV1YuhOwR5QjT6J6Psl9wP1MWi3YtQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2016 12:32:12.7323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB1884 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00021.txt.bz2 Yao Qi writes: > On 16-12-13 13:30:02, Tim Newsome wrote: >> Actually, this seems to work inside breakpoint_kind_from_pc(): >> ``` >> struct frame_info *frame = get_current_frame (); >> uint32_t misa = get_frame_register_unsigned (frame, RISCV_CSR_MISA_REGNUM); >> ``` >> >> Is that kosher? If so, is there any reason for me to implement >> breakpoint_kind_from_current_state? > > I'd like not to do so. Can't you decode the instruction to see whether > it is compressed or uncompressed? I also think it is a good idea to > make a decision based on ELF info, as you mentioned in the first email. Correct me if I'm wrong but reading the RISC-V arch manual, it seems like the MISA register information is static. So unlike arm where the ISA might change, on RISC-V it is static for the life of the program ? If that's true, and that you can't decode the instruction, it doesn't seem that bad to use the register in kind_from_pc ? Yao, was your concern that this would be non-static, or there is another reason ? However thinking about the ELF info, could you elaborate on why it may not reflect what is actually being executed ? And how this is a problem ? A note about _from_current_state too this is used while single_stepping since GDB knows it's about to set a breakpoint from a known state to the next location, this differs from from_pc which is used to set a pc from any state to any location. So in your case it's really from_pc that you want. Thanks, Antoine