From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30802 invoked by alias); 19 Nov 2002 13:00:02 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 30740 invoked from network); 19 Nov 2002 12:59:59 -0000 Received: from unknown (HELO zenia.red-bean.com) (66.244.67.22) by sources.redhat.com with SMTP; 19 Nov 2002 12:59:59 -0000 Received: (from jimb@localhost) by zenia.red-bean.com (8.11.6/8.11.6) id gAJChN923042; Tue, 19 Nov 2002 07:43:23 -0500 To: Alexander Larsson Cc: gdb@sources.redhat.com Subject: Re: Final separate debug info patch References: From: Jim Blandy Date: Tue, 19 Nov 2002 05:00:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.92 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-11/txt/msg00219.txt.bz2 Some other stuff I've noticed: - In reread_symbols, it looks like we do throw away objfile->separate_debug_objfile if it doesn't match any more, but I don't see where we read in the new one. (I think this is the cause of the reread.exp failure.) - Similarly, if we start with an unseparated objfile, but then it is changed to a separated objfile, I don't see where reread_symbols loads the separated objfile's debug objfile. - In reread_symbols, if the new objfile's debug link has a different name, but the CRC's happen to match, it won't toss the old file. It seems to me that we should re-run find_separate_debug_file from scratch, and make sure the filename we get matches the existing separate_debug_objfile's name. In general, I'm not convinced that the change to reread_symbols really covers all the cases. I'll try to fix it.