From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-18113-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 2366 invoked by alias); 21 May 2004 07:50:56 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 2352 invoked from network); 21 May 2004 07:50:56 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 21 May 2004 07:50:56 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i4L7otGG022426;
	Fri, 21 May 2004 03:50:55 -0400
Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i4L7or003071;
	Fri, 21 May 2004 03:50:54 -0400
To: "Cuthbertson, Reva D." <reva_cuthbertson@hp.com>
Cc: <gdb@sources.redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: Question regarding execute_stack_op in dwarf2expr.c
References: <B6C7F31B85669143825614FC8FE64929014C1746@cacexc04.americas.cpqcorp.net>
From: Jim Blandy <jimb@redhat.com>
Date: Fri, 21 May 2004 07:50:00 -0000
In-Reply-To: <B6C7F31B85669143825614FC8FE64929014C1746@cacexc04.americas.cpqcorp.net>
Message-ID: <vt2fz9ui5o9.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-05/txt/msg00145.txt.bz2


"Cuthbertson, Reva D." <reva_cuthbertson@hp.com> writes:
> I have a question regarding execute_stack_op() in dwarf2expr.c.  
> In the switch statement where the binary operators are being 
> processed, should there be a "break" after the cases for 
> DW_OP_div and DW_OP_shr?  

Yes!  Thanks for pointing that out.  I've committed the following:

2004-05-21  Jim Blandy  <jimb@redhat.com>

	* dwarf2expr.c (execute_stack_op): Add 'break' statements after
	cases for DW_OP_div and DW_OP_shr.  (Thanks to Reva Cuthbertson.)

Index: gdb/dwarf2expr.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2expr.c,v
retrieving revision 1.11
diff -c -p -r1.11 dwarf2expr.c
*** gdb/dwarf2expr.c	17 Jan 2004 23:09:29 -0000	1.11
--- gdb/dwarf2expr.c	21 May 2004 07:48:13 -0000
*************** execute_stack_op (struct dwarf_expr_cont
*** 575,580 ****
--- 575,581 ----
  		break;
  	      case DW_OP_div:
  		binop = BINOP_DIV;
+                 break;
  	      case DW_OP_minus:
  		binop = BINOP_SUB;
  		break;
*************** execute_stack_op (struct dwarf_expr_cont
*** 595,600 ****
--- 596,602 ----
  		break;
  	      case DW_OP_shr:
  		binop = BINOP_RSH;
+                 break;
  	      case DW_OP_shra:
  		binop = BINOP_RSH;
  		val1 = value_from_longest (signed_address_type (), first);