From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28697 invoked by alias); 12 Oct 2007 20:29:48 -0000 Received: (qmail 28689 invoked by uid 22791); 12 Oct 2007 20:29:47 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Oct 2007 20:29:45 +0000 Received: from HOME-C4E4A596F7 ([81.5.32.245]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id JCF82218 (AUTH halo1); Fri, 12 Oct 2007 22:29:19 +0200 (IST) Date: Fri, 12 Oct 2007 20:29:00 -0000 Message-Id: From: Eli Zaretskii To: Joel Brobecker CC: drow@false.org, Kai.Tietz@onevision.com, gdb@sourceware.org In-reply-to: <20071012174218.GH4044@adacore.com> (message from Joel Brobecker on Fri, 12 Oct 2007 10:42:18 -0700) Subject: Re: Support of gdb for Windows 64 native systems Reply-to: Eli Zaretskii References: <20071011142348.GA18239@caradoc.them.org> <20071011145549.GA19918@caradoc.them.org> <20071012161132.GE4044@adacore.com> <20071012174218.GH4044@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00089.txt.bz2 > Date: Fri, 12 Oct 2007 10:42:18 -0700 > From: Joel Brobecker > Cc: drow@false.org, Kai.Tietz@onevision.com, gdb@sourceware.org > > > So what? the duplicates will never be linked into the same build. We > > already have duplicate code in targets that are alike, one more cannot > > hurt. > > I have to disagree on that. We're looking at duplicating 95% of > the code. That means duplicating 95% of the maintenance. I assumed the two files will have different maintainers, too. > > > In our merge, I counted 5 instances of "ifdef/ifndef __MINGW32__ > > > > You need to count "ifdef __CYGWIN__" as well. > > Actually, currently all except one such ifdef are used as "if on > windows". They look like this: > > #if defined(_WIN32) || defined(__CYGWIN__) Not in the GDB CVS. > #ifdef __MINGW32__ > #define MAXPATHLEN PATH_MAX > #endif This, for example, is strictly speaking wrong on Windows: Windows supports much longer file names (up to 32K), if you use Unicode APIs. > > > The rest seems to be in i386-win32-tdep.c which is a separate file. > > > > I don't see this file, either, so I cannot comment on that. > > Yes, this is normal, because this file is not part of the FSF CVS. > It's a separate file that would only be needed for native win32 support. Well, in that case, maybe you already refactored the code in a way that makes my points moot.