From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22470 invoked by alias); 14 Aug 2014 13:57:07 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 22461 invoked by uid 89); 14 Aug 2014 13:57:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 13:57:05 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 83913AB1E; Thu, 14 Aug 2014 13:57:02 +0000 (UTC) From: Andreas Schwab To: Joel Brobecker Cc: Gary Benson , Mike Frysinger , gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages References: <20140814083231.GA6283@blade.nx> <6036430.RnprRWgZmF@vapier> <20140814131206.GA12746@blade.nx> <20140814132939.GH4924@adacore.com> <20140814134807.GI4924@adacore.com> X-Yow: Kids, the seven basic food groups are GUM, PUFF PASTRY, PIZZA, PESTICIDES, ANTIBIOTICS, NUTRA-SWEET and MILK DUDS!! Date: Thu, 14 Aug 2014 13:57:00 -0000 In-Reply-To: <20140814134807.GI4924@adacore.com> (Joel Brobecker's message of "Thu, 14 Aug 2014 06:48:07 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-08/txt/msg00029.txt.bz2 Joel Brobecker writes: >> > No, I strongly object to #5. The ChangeLog entries are part of >> > the email to be sent along with the patch to be reviewed, We had >> > that discussion many many years ago, and at the time, people >> > wanted the CL entry in the email, rather than as a diff. >> >> How does this have anything to do with the commit message? > > The email can be sent nearly verbatim using "git send-email". The use of send-email is not a requirement. > This is an objective that can be achieved with zero extra work > if you consider the other reasons I gave why I think the CL entry > should be in the revision log. That can also be achieved without the duplication in the commit message. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."