Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: ppluzhnikov@google.com (Paul Pluzhnikov)
Cc: gdb@sourceware.org, archer@sourceware.org, dje@google.com
Subject: Re: [python] Pretty-printers and addressprint
Date: Tue, 10 Nov 2009 15:45:00 -0000	[thread overview]
Message-ID: <m3zl6uct3f.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20091110021158.C3C2576D70@ppluzhnikov.mtv.corp.google.com> (Paul 	Pluzhnikov's message of "Mon, 9 Nov 2009 18:11:58 -0800 (PST)")

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> The issue I am having is there is no apparent way to get rid of the
Paul> address from python side (address is not printed when the printer
Paul> returns a python string instead of a value), whereas if the
Paul> printer really wants to print the address, it can trivally add
Paul> it back by returning appropriate python string.

Adding it manually like that will also affect MI output, which may not
be what you really want.

Paul> Should the decision to print addresses be deferred to the
Paul> pretty-printer? Is the patch below reasonable?

I'm ok with it.  If nobody complains this week, check it in.

Tom


      parent reply	other threads:[~2009-11-10 15:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10  8:37 Paul Pluzhnikov
2009-11-10  9:24 ` Elmenthaler, Jens
2009-11-10 10:22   ` Paul Pluzhnikov
2009-11-10 11:53     ` Phil Muldoon
2009-11-10 15:06       ` André Pönitz
2009-11-10 15:53         ` Tom Tromey
2009-11-10 15:15     ` Paul Koning
2009-11-10 17:03       ` Paul Pluzhnikov
2009-11-10 18:49         ` Paul Koning
2009-11-10 18:56         ` Tom Tromey
2009-11-10 19:07           ` Paul Pluzhnikov
2009-11-11  2:06             ` Tom Tromey
2009-11-10 15:45 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zl6uct3f.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=archer@sourceware.org \
    --cc=dje@google.com \
    --cc=gdb@sourceware.org \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox