Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "André Pönitz" <andre.poenitz@nokia.com>
Cc: ext Andrew Oakley <andrew@ado.is-a-geek.net>,
	       Joachim Protze <joachim.protze@wh2.tu-dresden.de>,
	       "gdb\@sourceware.org" <gdb@sourceware.org>
Subject: Re: Python API - pretty printing complex types
Date: Thu, 10 Mar 2011 21:25:00 -0000	[thread overview]
Message-ID: <m3y64m8y7z.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201103101007.21382.andre.poenitz@nokia.com> (=?utf-8?Q?=22An?= =?utf-8?Q?dr=C3=A9_P=C3=B6nitz=22's?=	message of "Thu, 10 Mar 2011 10:07:21 +0100")

>>>>> "André" == André Pönitz <andre.poenitz@nokia.com> writes:

>> I don't know about "expansion state" it feels like it is GDBs job to
>> manage that rather than the pretty printers themselves. 

André> I'd say it's a frontend's job to maintain the expansion state and
André> communicate that to gdb when asking for "expanded data".

If I understand correctly, then I think the varobj stuff does this ok.
It is the front end's choice whether to fetch varobj children, and how
many to fetch.  Front ends do have to do a little dance to make the
"windowing" work out right, but it isn't too bad.

Also, the pretty-printer API was designed so that a printer can be
written to compute data lazily, to avoid over-fetching.  There are still
some wrinkles here, I think strings still don't work completely
properly.  I think there is still a PR open about this.

I know you aren't using varobj.  We could probably expose more of the
pretty-printer stuff to pure Python if you'd find that helpful...
though I suspect just the existing gdb.default_visualizer is enough.

André> It would be perfect if the pretty-printers-can-return-pretty-printers 
André> approach would also allow to (easily) feed  the pretty printers with 
André> per-value individual data. I found this pretty useful for "patchwork"
André> applications, that cannot easily use global settings for everything.
André> [In some cases you would like to do things like "display char * as
André> Latin1, but in some cases it's UTF-8, sometimes it's a \0-separated and
André>  \0\0-terminated 'list' of strings,  and sometimes really only a pointer
André> to a single char". Or you have some numerical data in an array that you'd
André> like to run through xplot as "pretty printer", but you don't want to 
André> invoke that on every value of type std::vector<double>. Things like that.]

varobj lets you assign a printer to a specific varobj, but I'm not sure
if anything uses this, and it probably only makes sense if there is
prior coordination with the front end.

Handling this via sub-pretty-printers for (e.g.) specific fields in
known structures seems reasonable.  But I don't know a fully general way
to handle this, like if the user wants "print some_global_string" to
automatically know to use a different encoding.

Tom


  reply	other threads:[~2011-03-10 21:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09  0:43 Andrew Oakley
2011-03-09  8:06 ` Joachim Protze
2011-03-10 21:08   ` Tom Tromey
     [not found] ` <201103090954.49355.andre.poenitz@nokia.com>
2011-03-09 19:28   ` Andrew Oakley
2011-03-10  9:07     ` André Pönitz
2011-03-10 21:25       ` Tom Tromey [this message]
2011-03-11  7:41         ` Joachim Protze
2011-03-11 11:25         ` André Pönitz
2011-03-10 21:11     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y64m8y7z.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=andre.poenitz@nokia.com \
    --cc=andrew@ado.is-a-geek.net \
    --cc=gdb@sourceware.org \
    --cc=joachim.protze@wh2.tu-dresden.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox