Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: GDB Development <gdb@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Should a DW_OP_implicit_value be taken from the left end?
Date: Wed, 21 Dec 2016 19:42:00 -0000	[thread overview]
Message-ID: <m3y3z95ase.fsf@oc1027705133.ibm.com> (raw)

The following patch changed how sub-values of a DW_OP_implicit_value are
extracted on big-endian platforms:

  https://sourceware.org/ml/gdb-patches/2011-08/msg00123.html

The patch seems to assume that the placement rule is similar as for
DW_OP_stack_value.  I think that's wrong; DW_OP_implicit_value should
always be taken from the left end.  (See rationale below for an
explanation.)  And I'd like to know whether anyone objects.

I'm in the process of preparing a patch series for fixing various
problems with DWARF piece handling, and the series currently contains a
patch for reverting the above patch's effect on DW_OP_implicit_value.

Rationale:

Since DW_OP_implicit_value can express arbitrary amounts of structured
or unstructured data, the notion of a "least significant byte" is
meaningless.  The patch above makes it impossible for a
DW_OP_implicit_pointer operation to refer to any sub-value within a
DW_OP_implicit_value on big-endian targets.

E.g., consider this code snippet:

  const char foo[] = "Hello, world!";
  char *a = &foo[0];
  char *b = &foo[7];

IMHO the compiler should be able to describe `foo' with a single
DW_OP_implicit_value operation and `a' and `b' as DW_OP_implicit_pointer
operations pointing into that value.

Any objections?

--
Andreas


             reply	other threads:[~2016-12-21 19:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 19:42 Andreas Arnez [this message]
2016-12-21 21:39 ` Jan Kratochvil
2016-12-23 18:18   ` Andreas Arnez
2017-01-01 20:13     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y3z95ase.fsf@oc1027705133.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox