From: Tom Tromey <tromey@redhat.com>
To: "Philip Lee \(IDEAS\)" <Phil.Lee@morganstanley.com>
Cc: gdb@sources.redhat.com
Subject: Re: Removing -Wunused warnings
Date: Thu, 02 Jul 2009 14:33:00 -0000 [thread overview]
Message-ID: <m3ws6r17fo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <fe6bf5dc0907011254h3b81b354p33d3a1f5bf343b31@mail.gmail.com> (Philip Lee's message of "Wed\, 1 Jul 2009 15\:54\:09 -0400")
>>>>> "Phil" == Philip Lee (IDEAS) <Phil.Lee@morganstanley.com> writes:
Phil> I thought I'd see if I can remove at least some of the 'unused
Phil> variable' warnings generated when compiling with -Wunused. I haven't
Phil> committed any code before and I figure that's a good way to figure out
Phil> the build system and code layout.
Sounds good.
Phil> I've had a read of the CONTRIBUTING page, but if someone could ping me
Phil> as to whether it's better to submit one patch or a series of them and
Phil> anything else I'm likely to get wrong I'd appreciate it.
Bigger patches are harder to review. So, you're likely to get a
response more quickly to smaller patches.
Do you have your copyright assignment in place? If not, contact me
and I will get you started. It is good to get this out of the way
early.
The usual stuff people get wrong is formatting nits -- read the GNU
coding standards, especially the stuff about formatting C and the
stuff about writing ChangeLog entries.
Tom
prev parent reply other threads:[~2009-07-02 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 19:54 Philip Lee (IDEAS)
2009-07-02 14:33 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ws6r17fo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Phil.Lee@morganstanley.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox