From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30218 invoked by alias); 9 Nov 2009 16:42:10 -0000 Received: (qmail 30207 invoked by uid 22791); 9 Nov 2009 16:42:10 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 16:42:04 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA9Gg1gZ017556; Mon, 9 Nov 2009 11:42:01 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA9Gg1Nv026292; Mon, 9 Nov 2009 11:42:01 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nA9Gg056002532; Mon, 9 Nov 2009 11:42:00 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 2676F3782CF; Mon, 9 Nov 2009 09:41:58 -0700 (MST) From: Tom Tromey To: Arjun Roy Cc: gdb@sourceware.org Subject: Re: Python Scripting Question References: <4AF63479.7010602@gmail.com> Reply-To: tromey@redhat.com Date: Mon, 09 Nov 2009 17:23:00 -0000 In-Reply-To: (Tom Tromey's message of "Mon, 09 Nov 2009 09:25:19 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00090.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Arjun> Traceback (most recent call last): Arjun> File "", line 2, in Arjun> TypeError: argument 1 must be string without null bytes, not str Arjun> Error while executing Python code. Arjun> Is this a bug, am I misunderstanding the right way to do it, or what? Tom> It is a bug. I looked into this a little. The fix is to make python.c:execute_gdb_command copy the command string before passing it to execute_command. This avoids gdb commands trashing Python-owned strings. It isn't clear to me that gdb commands are allowed to overwrite their argument strings, though. Are they? disassemble_command does do this, but it seems wrong to me -- won't it permanently modify the command stored in a command script? I'll check in the python fix after testing. Tom