From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21179 invoked by alias); 1 Apr 2003 01:38:45 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 21050 invoked from network); 1 Apr 2003 01:38:40 -0000 Received: from unknown (63.201.54.26) by sources.redhat.com with QMTP; 1 Apr 2003 01:38:40 -0000 Received: (qmail 26869 invoked by uid 10); 1 Apr 2003 01:38:38 -0000 Received: (qmail 15361 invoked by uid 500); 1 Apr 2003 01:38:48 -0000 Mail-Followup-To: ac131313@redhat.com, carlton@math.stanford.edu, gdb@sources.redhat.com, binutils@sources.redhat.com, hp@bitrange.com To: Hans-Peter Nilsson Cc: Andrew Cagney , David Carlton , gdb , Subject: Re: gdb.mi/mi-cli.exp failures References: From: Ian Lance Taylor Date: Tue, 01 Apr 2003 01:38:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-04/txt/msg00001.txt.bz2 Hans-Peter Nilsson writes: > On Mon, 31 Mar 2003, Andrew Cagney wrote: > > And this: > > > > > - return concat (filename); > > > + return filename; > > > > (remembering that the patch is backwards) doesn't look so good. It > > should be: > > > > concat (filename, NULL); > > > > perhaps > > > > xstrdup (filename) > > > > would be easier to read :-) > > \begin{chant} There must be no xstrdup calls in bfd. BFD must > not abort; it's a library and the caller must handle allocation > failures. There may be xstrdup calls in bfd already, but please > don't add new ones. \end{chant} Could use strdup, though, not that I know the context here. Ian