From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-26953-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 21892 invoked by alias); 28 Nov 2006 19:01:02 -0000
Received: (qmail 21881 invoked by uid 22791); 28 Nov 2006 19:01:01 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Nov 2006 19:00:53 +0000
Received: (qmail 23915 invoked from network); 28 Nov 2006 19:00:51 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 28 Nov 2006 19:00:51 -0000
To: Nitin Gupta <ngupta@mvista.com>
Cc: gdb@sourceware.org
Subject: Re: [PATCH]: Clarify the warning displayed when you debug a core file  for the wrong architecture.
References: <456B8B19.8050403@mvista.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Tue, 28 Nov 2006 19:01:00 -0000
In-Reply-To: <456B8B19.8050403@mvista.com> (Nitin Gupta's message of "Mon, 27 Nov 2006 17:04:25 -0800")
Message-ID: <m3slg3tmyh.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00198.txt.bz2


Nitin Gupta <ngupta@mvista.com> writes:
> Pushing one of the old patches from Daniel into FSF.
>
> 2002-08-30  Daniel Jacobowitz  <drow@mvista.com>
>
>        * corelow.c (get_core_register_section): Clarify warning.
>
> Index: gdb-6.3.90_20051109/gdb/corelow.c
> ===================================================================
> --- gdb-6.3.90_20051109.orig/gdb/corelow.c      2005-07-04
> 13:29:10.000000000 +0000
> +++ gdb-6.3.90_20051109/gdb/corelow.c   2005-11-09 23:23:54.000000000 +0000
> @@ -462,7 +462,10 @@
>   if (! section)
>     {
>       if (required)
> +      {
>        warning (_("Couldn't find %s registers in core file."), human_name);
> +       warning (_("Core file may be for a different architecture.\n"));
> +      }
>       return;
>     }

I don't object to this patch, but I wonder if there isn't a better
place to do the check, where we could issue a more informative
message.

Does this warning ever come about when the core file is *not* of a
different architecture?  I'd assume not, since the caller indicated
that the section in question is required.

(Sorry if this patch has been discussed before --- I couldn't find the
thread in the archives.)