From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11750 invoked by alias); 9 Nov 2009 17:23:12 -0000 Received: (qmail 11742 invoked by uid 22791); 9 Nov 2009 17:23:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 17:23:06 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HN4wS012295; Mon, 9 Nov 2009 12:23:04 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HN4Yr020668; Mon, 9 Nov 2009 12:23:04 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HN3vT006501; Mon, 9 Nov 2009 12:23:03 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id C2B503782CF; Mon, 9 Nov 2009 10:23:02 -0700 (MST) From: Tom Tromey To: Arjun Roy Cc: gdb@sourceware.org Subject: Re: Python Scripting Question References: <4AF63479.7010602@gmail.com> <20091109171958.GA24542@caradoc.them.org> Reply-To: tromey@redhat.com Date: Mon, 09 Nov 2009 18:12:00 -0000 In-Reply-To: <20091109171958.GA24542@caradoc.them.org> (Daniel Jacobowitz's message of "Mon, 9 Nov 2009 12:19:58 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00093.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: Daniel> On Mon, Nov 09, 2009 at 09:41:54AM -0700, Tom Tromey wrote: >> It isn't clear to me that gdb commands are allowed to overwrite their >> argument strings, though. Are they? disassemble_command does do this, >> but it seems wrong to me -- won't it permanently modify the command >> stored in a command script? Daniel> Is it this bit? Daniel> /* Two arguments. */ Daniel> *space_index = '\0'; Yeah. Daniel> I don't think we should let commands modify their argument string. Me neither. For the Python case I think we still have to be defensive, because it seems that a command might temporarily modify its argument (I am pretty sure this happens but I don't know how often), but even this sort of modification could cause problems, if the command itself can cause Python code to be called. Tom