From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19985 invoked by alias); 5 Dec 2006 21:56:53 -0000 Received: (qmail 19731 invoked by uid 22791); 5 Dec 2006 21:56:52 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Dec 2006 21:56:48 +0000 Received: (qmail 12453 invoked from network); 5 Dec 2006 21:56:47 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Dec 2006 21:56:47 -0000 To: Markus Deuling Cc: Joel Brobecker , gdb@sourceware.org Subject: Re: GDB 6.5.90 available for testing (GDB 6.6 pre-release) References: <20061202192351.GY3304@adacore.com> <4573EBCD.90505@de.ibm.com> <20061204182108.GA11343@adacore.com> <4575197F.7020602@de.ibm.com> <20061205200927.GA25631@nevyn.them.org> From: Jim Blandy Date: Tue, 05 Dec 2006 21:56:00 -0000 In-Reply-To: <20061205200927.GA25631@nevyn.them.org> (Daniel Jacobowitz's message of "Tue, 5 Dec 2006 15:09:27 -0500") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00049.txt.bz2 Daniel Jacobowitz writes: > On Tue, Dec 05, 2006 at 11:12:59AM -0800, Jim Blandy wrote: >> >> Here's the patch I've been using for this. It'd be better to rework >> the way those functions use those obstacks, but... > > I might be mistaken, but I think calling obstack_init here is a memory > leak. [reads obstack code] You're right. Jeez. H.J.'s patch looks okay to me.