From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9714 invoked by alias); 28 Mar 2005 02:19:56 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 9675 invoked from network); 28 Mar 2005 02:19:53 -0000 Received: from unknown (205.217.158.180) by sourceware.org with QMTP; 28 Mar 2005 02:19:53 -0000 Received: (qmail 19854 invoked by uid 10); 28 Mar 2005 02:19:52 -0000 Received: (qmail 27981 invoked by uid 500); 28 Mar 2005 02:19:42 -0000 To: DJ Delorie Cc: mark.kettenis@xs4all.nl, gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org Subject: Re: [PATCH/libiberty] Add missing in unlink-if-ordinary.c References: <200503261421.j2QEL6ll019253@elgar.sibelius.xs4all.nl> <16965.28989.543273.976317@cuddles.cambridge.redhat.com> <200503261438.j2QEcTxo024182@elgar.sibelius.xs4all.nl> <200503280207.j2S27WBR010185@greed.delorie.com> From: Ian Lance Taylor Date: Mon, 28 Mar 2005 02:19:00 -0000 In-Reply-To: <200503280207.j2S27WBR010185@greed.delorie.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-03/txt/msg00253.txt.bz2 DJ Delorie writes: > > You must wrap this in #ifdef HAVE_SYS_TYPES_H > > > > Really? All the other files in libiberty include this file unconditionally. > > Normally I would say "that means they're all broken" but the ongoing > ansification means we probably don't need to check for that any more. is not an ISO C header file. But it is in POSIX.1. And it is available on every Unix system. Because of that, it is available on every Unix workalike system. Ian