From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 426 invoked by alias); 5 Dec 2006 19:12:22 -0000 Received: (qmail 418 invoked by uid 22791); 5 Dec 2006 19:12:21 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Dec 2006 19:12:14 +0000 Received: (qmail 24056 invoked from network); 5 Dec 2006 19:12:12 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Dec 2006 19:12:12 -0000 To: Markus Deuling Cc: Joel Brobecker , gdb@sourceware.org Subject: Re: GDB 6.5.90 available for testing (GDB 6.6 pre-release) References: <20061202192351.GY3304@adacore.com> <4573EBCD.90505@de.ibm.com> <20061204182108.GA11343@adacore.com> <4575197F.7020602@de.ibm.com> From: Jim Blandy Date: Tue, 05 Dec 2006 19:12:00 -0000 In-Reply-To: <4575197F.7020602@de.ibm.com> (Markus Deuling's message of "Tue, 05 Dec 2006 08:02:23 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00044.txt.bz2 Here's the patch I've been using for this. It'd be better to rework the way those functions use those obstacks, but... 2006-12-05 Jim Blandy * cp-valprint.c (cp_print_value_fields, cp_print_value): Initialize tmp_obstack, to avoid warnings. * p-valprint.c (pascal_object_print_value_fields) (pascal_object_print_value): Same. diff -rN -u old-lval/gdb/cp-valprint.c new-lval/gdb/cp-valprint.c --- gdb/cp-valprint.c 2006-12-05 11:11:42.000000000 -0800 +++ gdb/cp-valprint.c 2006-12-05 11:11:43.000000000 -0800 @@ -269,6 +269,9 @@ char *last_dont_print = obstack_next_free (&dont_print_statmem_obstack); int fields_seen = 0; + /* This isn't necessary, but it avoids compiler warnings. */ + obstack_init (&tmp_obstack); + CHECK_TYPEDEF (type); fprintf_filtered (stream, "{"); @@ -531,6 +534,9 @@ int thisoffset; struct type *thistype; + /* This isn't necessary, but it avoids compiler warnings. */ + obstack_init (&tmp_obstack); + if (dont_print_vb == 0) { /* If we're at top level, carve out a completely fresh diff -rN -u old-lval/gdb/p-valprint.c new-lval/gdb/p-valprint.c --- gdb/p-valprint.c 2006-12-05 11:11:42.000000000 -0800 +++ gdb/p-valprint.c 2006-12-05 11:11:44.000000000 -0800 @@ -756,6 +756,9 @@ struct obstack tmp_obstack; char *last_dont_print = obstack_next_free (&dont_print_statmem_obstack); + /* This isn't necessary, but it avoids compiler warnings. */ + obstack_init (&tmp_obstack); + CHECK_TYPEDEF (type); fprintf_filtered (stream, "{"); @@ -927,6 +930,9 @@ = (struct type **) obstack_next_free (&dont_print_vb_obstack); int i, n_baseclasses = TYPE_N_BASECLASSES (type); + /* This isn't necessary, but it avoids compiler warnings. */ + obstack_init (&tmp_obstack); + if (dont_print_vb == 0) { /* If we're at top level, carve out a completely fresh