From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7591 invoked by alias); 15 Jun 2011 15:37:43 -0000 Received: (qmail 7371 invoked by uid 22791); 15 Jun 2011 15:37:42 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jun 2011 15:37:27 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5FFb53Y028943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Jun 2011 11:37:05 -0400 Received: from localhost.localdomain (ovpn-113-70.phx2.redhat.com [10.3.113.70]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5FFb3l6023252; Wed, 15 Jun 2011 11:37:04 -0400 From: Phil Muldoon To: Joel Brobecker Cc: gdb@sourceware.org Subject: Re: ARI/Commit rules References: <20110615152451.GN5944@adacore.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Wed, 15 Jun 2011 15:37:00 -0000 In-Reply-To: <20110615152451.GN5944@adacore.com> (Joel Brobecker's message of "Wed, 15 Jun 2011 08:24:51 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00106.txt.bz2 Joel Brobecker writes: > I think it would be nice to be able to run this script by hand > from a checkout, and it shouldn't be too difficult, since it's > mostly an awk script. And for those that use git, we could > produce a hook as well, I think. We might have some issues > with volume (number of warnings due to the already-present > violations) though, or perhaps performance. I don't know about > others, but since using git, I have been so spoiled that I expect > every operation to be instantaneous... It would be nice to fix those warnings eventually. I believe a pre-commit hook would only operate on your diffs, though. Anyway we cannot use that as the GIT repository is read only. So to me, an ideal thing would be just to run it on my files that I have changed, or even better a patch I have generated. What do you think? Cheers Phil