From: Tom Tromey <tromey@redhat.com>
To: "Petr Hluzín" <petr.hluzin@gmail.com>
Cc: paawan oza <paawan1982@yahoo.com>,
gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] arm reversible : <phase_2_complete>
Date: Mon, 02 May 2011 14:47:00 -0000 [thread overview]
Message-ID: <m3hb9d6tyl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <BANLkTin0hycedjgPRDHO7exEhS0SGQw3qQ@mail.gmail.com> ("Petr =?utf-8?Q?Hluz=C3=ADn=22's?= message of "Sun, 1 May 2011 03:19:43 +0200")
>>>>> "Petr" == Petr Hluzín <petr.hluzin@gmail.com> writes:
Petr> I also recommend to define a local variable in the smalles scope
Petr> possible, however I understand that many
Petr> programmers use weak tools and knowing its definition requires more
Petr> effort than placing cursor on the variable - therefore they prefer
Petr> definitions at the start of function.
I agree, using the smallest scope is generally preferable.
This practice makes it simpler to reason about the code.
Petr> My IDE has a spellchecker which underlines typos. No effort required.
Petr> (Consider upgrading your tools.)
I'm curious to know what IDE you use for working on GDB.
For those using Emacs, M-x flyspell-prog-mode will spell-check in
comments and strings.
Petr> Also I have no vote in GDB development, so my patch approval would
Petr> have little impact.
I appreciate thoughtful reviews from anyone, regardless of their
official status. I think GDB patches still spend too much time waiting
for review, and this sort of thing can help speed things up.
Petr> GDB commiters: please reply whether you agree with my review. (So that
Petr> paawan oza does not spend effort in vain.)
I thought it was quite good. Thanks for doing this.
Tom
next prev parent reply other threads:[~2011-05-02 14:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 4:08 [PATCH] arm reversible : progress <patch_1_phase_2> paawan oza
2011-03-03 18:32 ` Tom Tromey
2011-03-03 18:37 ` Michael Snyder
2011-03-03 18:59 ` Pedro Alves
2011-03-04 3:32 ` paawan oza
2011-03-04 3:56 ` paawan oza
2011-03-04 19:31 ` Tom Tromey
2011-03-04 20:09 ` Michael Snyder
2011-03-04 20:11 ` Tom Tromey
2011-04-10 9:41 ` [PATCH] arm reversible : progress <phase_2_complete> paawan oza
2011-04-11 3:05 ` Yao Qi
2011-04-11 4:52 ` paawan oza
2011-04-12 10:58 ` Yao Qi
2011-04-16 21:03 ` paawan oza
2011-04-20 19:16 ` [PATCH] arm reversible : <phase_2_complete> paawan oza
2011-04-21 20:55 ` Petr Hluzín
2011-04-22 5:49 ` paawan oza
2011-04-22 5:55 ` oza Pawandeep
2011-04-25 14:03 ` paawan oza
2011-05-01 1:20 ` Petr Hluzín
2011-05-02 14:47 ` Tom Tromey [this message]
2011-05-04 21:33 ` Petr Hluzín
2011-05-05 15:29 ` Tom Tromey
2011-05-07 13:50 ` paawan oza
2011-05-07 13:56 ` paawan oza
[not found] ` <172713.29831.qm__351.089161313389$1303740245$gmane$org@web112503.mail.gq1.yahoo.com>
2011-04-25 19:57 ` Tom Tromey
2011-04-28 18:26 ` paawan oza
2011-04-28 19:00 ` Tom Tromey
2011-04-28 19:22 ` paawan oza
[not found] ` <727567.12089.qm__13056.408687453$1304018591$gmane$org@web112511.mail.gq1.yahoo.com>
2011-04-28 19:36 ` Tom Tromey
2011-04-30 16:16 ` paawan oza
2011-05-02 13:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hb9d6tyl.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=paawan1982@yahoo.com \
--cc=petr.hluzin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox